init: Remove deprecated args from hidden args #14272

1. 
   MarcoFalke commented at 8:39 pm on September 19, 2018: member

   The args have been deprecated since 0.17 (maybe longer) and since we reject unknown args, there is no need to add deprecated args to the list of hidden args and then hand-craft an error message if a user provides them.
2. MarcoFalke added the label Utils/log/libs on Sep 19, 2018
3. init: Remove deprecated args from hidden args fa910e4301
4. MarcoFalke force-pushed on Sep 19, 2018
5. 
   ken2812221 commented at 10:54 pm on September 19, 2018: contributor

   utACK fa910e4
6. 
   practicalswift commented at 5:20 am on September 20, 2018: contributor

   utACK fa910e43014d7b6a22f95e2c65b1c4a3e8d5cedc
7. 
   laanwj commented at 7:03 am on September 20, 2018: member

   -rpcssl, wow, that one has been gone for a while…

   ACK

8. 
   scravy commented at 7:58 am on September 20, 2018: contributor

   utACK fa910e4
9. 
   fanquake commented at 12:02 pm on September 20, 2018: member

   utACK fa910e4
10. MarcoFalke merged this on Sep 20, 2018
11. MarcoFalke closed this on Sep 20, 2018

    ---

12. MarcoFalke referenced this in commit 9a3a984bb8 on Sep 20, 2018
13. MarcoFalke deleted the branch on Sep 20, 2018
14. 
    promag commented at 12:48 pm on September 20, 2018: member

    ACK fa910e4, verified all occurrences of these deprecated args were removed.
15. 
    jnewbery commented at 1:51 pm on September 20, 2018: member

    I think you can also remove -usehd, since it doesn’t have any effect from 0.16 onwards.
16. 
    MarcoFalke commented at 4:37 pm on September 20, 2018: member

    @jnewbery It is currently used to inform the user of “You can’t enable/disable HD on an already existing non-HD/HD wallet”. I think it gives users a feeling of assurance that their existing wallet file is indeed hd or non-hd.
17. 
    MarcoFalke commented at 4:39 pm on September 20, 2018: member

    I’ll leave the decision whether this can be removed to the wallet-people.
18. 
    jnewbery commented at 6:42 pm on September 20, 2018: member

    paging wallet-people
19. MarcoFalke referenced this in commit ae1cc010b8 on Sep 26, 2018
20. in src/init.cpp:970 in fa910e4301

    965-    if (gArgs.GetBoolArg("-debugnet", false))
    966-        InitWarning(_("Unsupported argument -debugnet ignored, use -debug=net."));
    967-    // Check for -socks - as this is a privacy risk to continue, exit here
    968-    if (gArgs.IsArgSet("-socks"))
    969-        return InitError(_("Unsupported argument -socks found. Setting SOCKS version isn't possible anymore, only SOCKS5 proxies are supported."));
    970-    // Check for -tor - as this is a privacy risk to continue, exit here
    

    ---

    ---

    

    luke-jr commented at 2:42 am on December 20, 2018:

    Won’t this just yield a warning now?

    ---

    

    MarcoFalke commented at 5:23 pm on December 20, 2018:

    Not that I am aware of

    ---

    

    luke-jr commented at 5:54 pm on December 20, 2018:

    If the user has tor=1 in bitcoin.conf, where will the InitError come from?

    ---

    

    MarcoFalke commented at 7:08 pm on December 20, 2018:

    Oh, I was testing src/qt/bitcoin-qt -notor, which gave me and still gives

    

21. deadalnix referenced this in commit d37a92f211 on Apr 20, 2020
22. ftrader referenced this in commit c077fc43cb on May 19, 2020
23. Munkybooty referenced this in commit 65a08b3535 on Jul 10, 2021
24. Munkybooty referenced this in commit eb0fc1387b on Jul 10, 2021
25. rkarthik2k21 referenced this in commit 7b24342f91 on Aug 9, 2021
26. rkarthik2k21 referenced this in commit 86907200a6 on Aug 16, 2021
27. UdjinM6 referenced this in commit 883c84aa3e on Aug 17, 2021
28. DrahtBot locked this on Sep 8, 2021

Contributors
MarcoFalke ken2812221 practicalswift laanwj scravy fanquake promag jnewbery luke-jr

Labels
Utils/log/libs