build: Add MSVC project files for bitcoin-wallet-tool #14284

1. 
   ken2812221 commented at 1:14 am on September 21, 2018: contributor

   Based on #13926. Add msvc project files for it
2. fanquake added the label Windows on Sep 21, 2018
3. 
   DrahtBot commented at 3:38 am on September 21, 2018: member

   • #14283 (WIP: Add wallet tool test by promag)
   • #13100 (gui: Add dynamic wallets support by promag)
   • #12246 (Bugfix: Only run bitcoin-tx tests when bitcoin-tx is enabled by luke-jr)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. [PoC] Add wallet inspection and modification tool "bitcoin-wallet-tool" 428823c2cc
5. fixups fdbb2d5872
6. in src/wallet/wallettool.cpp:132 in 36877aa5f3 outdated

   120+        std::string backup_filename;
   121+        if (!WalletBatch::Recover(path, (void*)&dummyWallet, WalletBatch::RecoverKeysOnlyFilter, backup_filename)) {
   122+            fprintf(stderr, "Salvage failed\n");
   123+            return false;
   124+        }
   125+        //TODO, set wallets best block to genesis to enforce a rescan
   

   ---

   ---

   

   practicalswift commented at 6:59 pm on September 22, 2018:

   02018-09-22 20:39:03 cpplint(pr=14284): src/wallet/wallettool.cpp:125:  Should have a space between // and comment  [whitespace/comments
   

   ---

   

   ken2812221 commented at 7:45 pm on September 22, 2018:

   This is not my commit, please comment on #13926.
7. ken2812221 force-pushed on Sep 24, 2018
8. build: Add MSVC project files for bitcoin-wallet-tool 44a11b0da8
9. ken2812221 force-pushed on Sep 24, 2018
10. 
    ken2812221 commented at 2:19 pm on September 24, 2018: contributor

    Rebased
11. 
    jnewbery commented at 2:21 pm on September 27, 2018: member

    Thanks for doing this @ken2812221 . I’ve squashed your changes into the commit in #13926. (I didn’t cherry pick as a separate commit to avoid breaking git bisect for msvc builds).
12. ken2812221 closed this on Sep 27, 2018

    ---

13. ken2812221 reopened this on Sep 27, 2018

    ---

14. ken2812221 closed this on Sep 27, 2018

    ---

15. ken2812221 deleted the branch on Sep 27, 2018
16. MarcoFalke locked this on Sep 8, 2021

Contributors
ken2812221 DrahtBot practicalswift jnewbery

Labels
Windows