tests: Use MakeUnique to construct objects owned by unique_ptrs #14287

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:make_unique-subset changing 9 files +20 −15

practicalswift commented at 9:05 AM on September 21, 2018: contributor
A subset of #14211 ("Use MakeUnique to construct objects owned by unique_ptrs") as suggested by @MarcoFalke in #14211 (comment).

Use MakeUnique to construct objects owned by unique_ptrs.

Rationale:
- MakeUnique ensures exception safety in complex expressions.
- MakeUnique gives a more concise statement of the construction.
tests: Use MakeUnique to construct objects owned by unique_ptrs b6718e373e
MarcoFalke added the label Docs on Sep 21, 2018
MarcoFalke added the label Tests on Sep 21, 2018
MarcoFalke commented at 12:09 PM on September 21, 2018: member

utACK b6718e373ed425fa2440ddd8f1b05c76b782dc2b
DrahtBot commented at 12:16 PM on September 21, 2018: member
Note to reviewers: This pull request conflicts with the following ones:
- #14224 (Document intentional and unintentional unsigned integer overflows (wraparounds) using annotations by practicalswift)
- #14010 (tests: Setup chain parameters (globalChainParams) when performing fuzzing initialization by practicalswift)
- #9381 (Remove CWalletTx merging logic from AddToWallet by ryanofsky)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
donaloconnor commented at 5:21 PM on September 21, 2018: contributor

utACK b6718e373ed425fa2440ddd8f1b05c76b782dc2b
MarcoFalke merged this on Sep 21, 2018
MarcoFalke closed this on Sep 21, 2018
MarcoFalke referenced this in commit 920c090f63 on Sep 21, 2018
practicalswift deleted the branch on Apr 10, 2021
Munkybooty referenced this in commit 25c9e682f6 on Jun 24, 2021
Munkybooty referenced this in commit 5f87520aa3 on Jun 24, 2021
Munkybooty referenced this in commit 6dcbddbf10 on Jun 28, 2021
Munkybooty referenced this in commit 36ba5267df on Jun 29, 2021
Munkybooty referenced this in commit afe42bd422 on Jun 29, 2021
Munkybooty referenced this in commit e48e6b5864 on Jun 29, 2021
gades referenced this in commit 2bfd797aac on May 1, 2022
malbit referenced this in commit 790788d3a3 on Aug 7, 2022
DrahtBot locked this on Aug 16, 2022

Contributors

Labels

Linked (view graph)

#14211 Use MakeUnique to construct objects owned by unique_ptrs