[gitian] use versioned unsigned tarballs instead of generically named ones #14325

pull achow101 wants to merge 1 commits into bitcoin:master from achow101:gitian-versions changing 1 files +4 −2
  1. achow101 commented at 2:12 AM on September 26, 2018: member

    Instead of re-naming the tarballs used for the code signing step to the generically named tarball that is used, keep the versioned naming. Only copy them to the correct filename when they are needed at build time.

    This makes it easier to handle situations when multiple different releases are being built simultaneously as the version that the code signatures are applied to will actually be the correct version and not require a rebuild to get the correct tarball.

  2. [gitian] use versioned unsigned tarballs instead of generically named ones
    Instead of re-naming the tarballs used for the code signing step to the generically
    named tarball that is used, keep the versioned naming. Only copy them to the
    correct filename when they are needed at build time.
    d813266db1
  3. fanquake added the label Scripts and tools on Sep 26, 2018
  4. fanquake requested review from theuni on Sep 27, 2018
  5. ken2812221 commented at 9:35 AM on September 27, 2018: contributor

    Concept ACK.

    How about moving them all to bitcoin-binaries and copying them to gitian-builder/inputs while signing?

  6. theuni approved
  7. theuni commented at 6:36 PM on September 27, 2018: member

    utACK d813266db1f23f49465aa2aca3c3c80a95cf63d9. Agree with ken2812221, that's similar to what I do locally. This looks fine too though.

  8. fanquake commented at 1:27 AM on September 28, 2018: member

    utACK d813266

  9. DrahtBot commented at 2:55 AM on September 28, 2018: member

    <!--32850dd3fdea838b4049e64f46995ea2-->

    Coverage Change (pull 14325) Reference (master)
    Lines +0.0088 % 87.0361 %
    Functions +0.0154 % 84.1130 %
    Branches -0.0047 % 51.5451 %
  10. laanwj merged this on Oct 1, 2018
  11. laanwj closed this on Oct 1, 2018

  12. laanwj referenced this in commit 1e8f88e071 on Oct 1, 2018
  13. UdjinM6 referenced this in commit 6f82a0fc38 on Sep 1, 2021
  14. UdjinM6 referenced this in commit c4d639c3cc on Sep 2, 2021
  15. UdjinM6 referenced this in commit fe03f20ccf on Sep 2, 2021
  16. UdjinM6 referenced this in commit bd25487a13 on Sep 2, 2021
  17. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-19 00:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me