threads: fix potential unitialized members in sched_param #14342

pull theuni wants to merge 1 commits into bitcoin:master from theuni:fix-musl-sched changing 1 files +15 −2

theuni commented at 10:53 PM on September 27, 2018: member

Building with gcc 8.2 against musl libc, which apparently has more attributes available in its sched_param. The following warnings were produced:

warning: missing initializer for member 'sched_param::sched_ss_low_priority' [-Wmissing-field-initializers]
warning: missing initializer for member 'sched_param::sched_ss_repl_period' [-Wmissing-field-initializers]
warning: missing initializer for member 'sched_param::sched_ss_init_budget' [-Wmissing-field-initializers]
warning: missing initializer for member 'sched_param::sched_ss_max_repl' [-Wmissing-field-initializers]

Since the current thread may have interesting non-zero values for these fields, we want to be sure to only change the intended one. Query and modify the current sched_param rather than starting from a zeroed one.

threads: fix unitialized members in sched_param

Building with gcc 8.2 against musl libc, which apparently has more attributes
available in its sched_param. The following warnings were produced:

    warning: missing initializer for member 'sched_param::sched_ss_low_priority' [-Wmissing-field-initializers]
    warning: missing initializer for member 'sched_param::sched_ss_repl_period' [-Wmissing-field-initializers]
    warning: missing initializer for member 'sched_param::sched_ss_init_budget' [-Wmissing-field-initializers]
    warning: missing initializer for member 'sched_param::sched_ss_max_repl' [-Wmissing-field-initializers]

Since the current thread may have interesting non-zero values for these fields,
we want to be sure to only change the intended one. Query and modify the
current sched_param rather than starting from a zeroed one.

8c0bcb9ba9

fanquake added the label Utils/log/libs on Sep 27, 2018
DrahtBot commented at 1:29 AM on September 28, 2018: member



Coverage Change (pull 14342) Reference (master)

Lines -0.0579 % 87.0361 %

Functions -0.0463 % 84.1130 %

Branches -0.0436 % 51.5451 %
practicalswift commented at 5:55 AM on September 28, 2018: contributor

Concept ACK

Nice find!
fanquake commented at 1:19 PM on October 14, 2018: member

Concept ACK

I assume this turned up during some 🐢 related work? I'm planning on getting setup to test that/musl going forward, so will give a proper ACK here if I get that done before this is merged.
DrahtBot commented at 11:16 AM on November 5, 2018: member

Needs rebase
DrahtBot added the label Needs rebase on Nov 5, 2018
practicalswift commented at 12:25 PM on November 5, 2018: contributor

@theuni I'd like to reproduce by building against musl myself - do you remember which build parameters you used? :-)
fanquake commented at 10:59 AM on November 29, 2018: member

Rebased in #14839.
fanquake closed this on Nov 29, 2018
laanwj referenced this in commit fcb6694a99 on Jan 16, 2019
laanwj removed the label Needs rebase on Oct 24, 2019
PastaPastaPasta referenced this in commit 31e18d0e23 on Jun 26, 2021
PastaPastaPasta referenced this in commit f591a545eb on Jun 26, 2021
PastaPastaPasta referenced this in commit b6faa97716 on Jun 27, 2021
PastaPastaPasta referenced this in commit f2b33a7d34 on Jun 28, 2021
MarcoFalke locked this on Dec 16, 2021

Coverage	Change (pull 14342)	Reference (master)
Lines	-0.0579 %	87.0361 %
Functions	-0.0463 %	84.1130 %
Branches	-0.0436 %	51.5451 %

Contributors

Labels

Linked (view graph)

#14839 [rebase] threads: fix unitialized members in sched_param