depends: fix bitcoin-qt back-compat with older freetype versions at runtime #14348

pull theuni wants to merge 1 commits into bitcoin:master from theuni:fix-qt-freetype-compat changing 1 files +1 −0
  1. theuni commented at 1:01 PM on September 28, 2018: member

    Fixes #14339. Thanks to @fanquake for confirming.

    A few years ago, libfreetype introduced FT_Get_Font_Format() as an alias for FT_Get_X11_Font_Format(), but FT_Get_X11_Font_Format() was kept for abi backwards-compatibility.

    Our qt bump to 5.9 introduced a call toFT_Get_Font_Format(). Replace it with FT_Get_X11_Font_Format() in order to remain compatibile with older freetype, which is still used by e.g. Ubuntu Trusty.

    Needs 0.17 backport.

  2. depends: fix bitcoin-qt back-compat with older freetype versions at runtime
    A few years ago, libfreetype introduced FT_Get_Font_Format() as an alias for
FT_Get_X11_Font_Format(), but FT_Get_X11_Font_Format() was kept for abi
backwards-compatibility.

Our qt bump to 5.9 introduced a call to FT_Get_Font_Format(). Replace it with
FT_Get_X11_Font_Format() in order to remain compatibile with older freetype,
which is still used by e.g. Ubuntu Trusty.
    430bf6c7a1
  3. theuni commented at 1:06 PM on September 28, 2018: member

    As an aside, there are several shared libs that we build in order to link qt against, but that we don't actually ship. libfreetype is one of them. We should downgrade those to the minimum viable versions in order to detect these issues at build-time.

  4. fanquake added the label Build system on Sep 28, 2018
  5. fanquake added the label Needs backport on Sep 28, 2018
  6. fanquake added this to the milestone 0.17.0 on Sep 28, 2018
  7. theuni commented at 1:29 PM on September 28, 2018: member

    For reference, here's the current implementation in freetype's git: https://git.savannah.gnu.org/cgit/freetype/freetype2.git/tree/src/base/ftfntfmt.c

  8. MarcoFalke added the label Needs gitian build on Sep 28, 2018
  9. laanwj removed this from the milestone 0.17.0 on Sep 28, 2018
  10. laanwj added this to the milestone 0.17.1 on Sep 28, 2018
  11. laanwj removed this from the milestone 0.17.1 on Sep 28, 2018
  12. laanwj added this to the milestone 0.17.0 on Sep 28, 2018
  14. luke-jr commented at 6:32 PM on September 28, 2018: member

    Would downgrading our freetype depends-build make this automagically work, or cause the Qt build to fail?

  15. theuni commented at 7:25 PM on September 28, 2018: member

    @luke-jr Should do the latter.

    It would either fail to compile due to a missing FT_Get_Font_Format() definition, or if that happened to be hard-coded somewhere, it would fail to link due to the unresolved symbol.

  16. jonasschnelli commented at 7:30 PM on September 28, 2018: contributor

    Tested ACK 430bf6c7a1a24a59050e7c9dac56b64b820edb43 on Ubuntu 14.04.05 via a Gitian Build (https://bitcoin.jonasschnelli.ch/build/811).

  17. fanquake commented at 9:33 AM on September 29, 2018: member

    tACK 430bf6c

    I tested the changes here: #14339 (comment)

  18. laanwj referenced this in commit 480d6bb078 on Sep 29, 2018
  19. laanwj removed the label Needs backport on Sep 29, 2018
  20. laanwj merged this on Sep 29, 2018
  21. laanwj closed this on Sep 29, 2018
  22. laanwj referenced this in commit c9327306b5 on Sep 29, 2018
  23. DrahtBot commented at 10:23 PM on September 29, 2018: member

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds for commit 0809e68a9084630ff4d11ec0503a3d0ab52bc6d7 (master):

    Gitian builds for commit b43ca245bfcc8797bafecc07b082c7fac75bbf40 (master and this pull):

  24. DrahtBot removed the label Needs gitian build on Sep 29, 2018
  25. uhliksk referenced this in commit 8640b8ed24 on Oct 18, 2018
  26. HashUnlimited referenced this in commit 3203e08bde on Oct 25, 2018
  27. UdjinM6 referenced this in commit 276e712bf0 on Dec 17, 2020
  28. gades referenced this in commit a0de712bd6 on Jun 24, 2021
  29. CryptoCentric referenced this in commit 31c49ef0ab on Jul 2, 2021
  30. DrahtBot locked this on Sep 8, 2021
Contributors
theunilaanwjluke-jrjonasschnellifanquakeDrahtBot
Labels
Build system

Milestone
0.17.0

Linked (view graph)
#14339 Qt 0.17.0rc4 (and master) not running on Ubuntu 14.04.5 LTS
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-18 15:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me