test: Inline scriptnum10 header #14440

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1810-testScriptNumHeader changing 3 files +172 −185

MarcoFalke commented at 7:41 AM on October 9, 2018: member

The header file was moved to test in #4160.

Currently make clean fails because da32bd80bf3cab07e12f574dafcf11345a961444 assumed that the BITCOIN_TESTS only contains cpp files.

The make clean failure can be solved by inlining the header file.
test: Inline scriptnum10 header fa8703ff87
MarcoFalke added the label Tests on Oct 9, 2018
MarcoFalke commented at 7:51 AM on October 9, 2018: member

Instead of inlining, I could move it to BITCOIN_TEST_SUITE, if people prefer.
murrayn commented at 11:52 AM on October 9, 2018: contributor

I was going to change https://github.com/bitcoin/bitcoin/commit/da32bd80bf3cab07e12f574dafcf11345a961444 but I think your BITCOIN_TEST_SUITE suggestion seems better.

Maybe BITCOIN_TESTS should be renamed BITCOIN_TESTS_CPP for clarity?
practicalswift commented at 12:29 PM on October 9, 2018: contributor

Concept ACK

Let's get this merged quickly – make clean is crucial :-)
Empact commented at 2:36 AM on October 10, 2018: member

I like the idea of moving to BITCOIN_TEST_SUITE.
jamesob commented at 2:38 AM on October 10, 2018: member

IMO we should do the simplest thing possible to make make clean work again (https://github.com/bitcoin/bitcoin/pull/14455) and only after that think about shuffling stuff around.
MarcoFalke closed this on Oct 10, 2018
MarcoFalke deleted the branch on Oct 10, 2018
MarcoFalke referenced this in commit dc8e6d04ea on Oct 10, 2018
PastaPastaPasta referenced this in commit c4a60148b9 on Jul 17, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#4160 Reduce bignum.h now it is only needed for scriptnum_tests #14455 build: unbreak `make clean`