bitcoin client 0.17.0 ignores wallet’s name (file) #14523

issue nikitasius openend this issue on October 19, 2018
  1. nikitasius commented at 9:48 pm on October 19, 2018: none

    Old config (version 0.15 and 0.16.0/0.16.3):

    0prune=8192
1rpcuser=rpc
2rpcpassword=rpc
3onlynet=ipv4
4testnet=1
5rpcbind=127.0.0.1:18332
6walletdir=/path/to/wallet/
7wallet=mywallet.dat

    It worked pretty nice.

    UPD: it does not worked in version 0.17.0 ! BTC client made a new wallet.dat file

    On version 0.17.0 i read what i can use full pathes to wallet files.

    0prune=8192
1rpcuser=rpc
2rpcpassword=rpc
3onlynet=ipv4
4testnet=1
5rpcbind=127.0.0.1:18332
6wallet=/path/to/wallet/mywallet.dat

    FAILS. It created wallet.dat in /path/to/wallet/ folder

    0prune=8192
1rpcuser=rpc
2rpcpassword=rpc
3onlynet=ipv4
4testnet=1
5rpcbind=127.0.0.1:18332
6walletdir=/path/to/wallet/
7wallet=/path/to/wallet/mywallet.dat

    FAILS. It created wallet.dat in ~/.bitcoin/wallets folder.

    Current config:

    0prune=8192
1rpcuser=rpc
2rpcpassword=rpc
3onlynet=ipv4
4testnet=1
5rpcbind=127.0.0.1:18332
6walletdir=/path/to/wallet/

    AND i renamed mywallet.dat into wallet.dat to let client work.

    I run bitcoin core client 0.17.0 on Linux 4.9.0-6-amd64 [#1](/bitcoin-bitcoin/1/) SMP Debian 4.9.88-1+deb9u1 (2018-05-07) x86_64 GNU/Linux.

  2. meshcollider added the label Wallet on Oct 19, 2018
  3. ryanofsky commented at 10:26 pm on October 19, 2018: member

    walletdir=/path/to/wallet/ wallet=mywallet.dat It worked pretty nice. UPD: it does not worked in version 0.17.0 ! BTC client made a new wallet.dat file

    I think I’m able to reproduce this. It looks like #11862 might be causing your wallet config argument to be ignored. Do you see this warning?

    0Warning: Config setting for -wallet only applied on test network when in [test] section.

    On version 0.17.0 i read what i can use full pathes to wallet files.

    We might need to clarify release notes, but this isn’t true. You can only specify full paths to wallet directories not wallet files. (Originally this was possible, but it was deemed too dangerous because it might mislead people into creating incomplete backups of wallets).

  4. nikitasius commented at 5:23 pm on October 20, 2018: none

    @ryanofsky , hi yes:

     0grep applied debug.log
 12018-10-19T21:04:04Z Warning: Config setting for -rpcbind only applied on test network when in [test] section.
 22018-10-19T21:04:04Z Warning: Config setting for -wallet only applied on test network when in [test] section.
 32018-10-19T21:16:02Z Warning: Config setting for -rpcbind only applied on test network when in [test] section.
 42018-10-19T21:16:02Z Warning: Config setting for -wallet only applied on test network when in [test] section.
 52018-10-19T21:21:35Z Warning: Config setting for -rpcbind only applied on test network when in [test] section.
 62018-10-19T21:21:35Z Warning: Config setting for -wallet only applied on test network when in [test] section.
 72018-10-19T21:23:35Z Warning: Config setting for -rpcbind only applied on test network when in [test] section.
 82018-10-19T21:23:35Z Warning: Config setting for -wallet only applied on test network when in [test] section.
 92018-10-19T21:30:02Z Warning: Config setting for -rpcbind only applied on test network when in [test] section.
102018-10-19T21:37:18Z Warning: Config setting for -rpcbind only applied on test network when in [test] section.
112018-10-19T21:37:18Z Warning: Config setting for -wallet only applied on test network when in [test] section.
122018-10-19T21:41:20Z Warning: Config setting for -rpcbind only applied on test network when in [test] section.

    it’s same debug.log i keep, records inside are from 14 october. 0.17.0 was installed yesterday.

  5. nikitasius commented at 5:24 pm on October 20, 2018: none
    but why i need (or not) to specity test section inside a config? i.e. i already specified a testnet.
  6. ryanofsky commented at 6:06 pm on October 20, 2018: member

    but why i need (or not) to specity test section inside a config? i.e. i already specified a testnet.

    Before #11862 and 0.17.0, you didn’t need to have -wallet and other “network-only” options under a network section. Now it looks you need to or they get ignored.

    I think this is a mistake, and we should backport a fix that will restore the old behavior. It don’t think it is ok to just start ignoring settings that used to work. We should probably keep the log message to encourage people to use network-specific sections and be more explicit about settings that are sensitive to which network is used, but we should not just be dropping the settings on the floor.

    It also seems like a mistake to me that -wallet is a “network-only” option but -walletdir is not. This is another thing that should probably be addressed.

  7. MarcoFalke added this to the milestone 0.17.1 on Oct 21, 2018
  8. MarcoFalke added the label Bug on Oct 21, 2018
  9. MarcoFalke added the label Utils/log/libs on Oct 21, 2018
  10. MarcoFalke removed the label Wallet on Oct 21, 2018
  11. MarcoFalke removed this from the milestone 0.17.1 on Dec 3, 2018
  12. MarcoFalke added this to the milestone 0.17.2 on Dec 3, 2018
  13. MarcoFalke commented at 6:19 pm on December 3, 2018: member
    Moving to 0.17.2
  14. MarcoFalke removed this from the milestone 0.17.2 on Mar 20, 2019
  15. MarcoFalke added this to the milestone 0.18.1 on Mar 20, 2019
  16. MarcoFalke removed this from the milestone 0.18.1 on Mar 20, 2019
  17. MarcoFalke commented at 9:21 pm on March 20, 2019: member
    Made it an error instead of warning in #15629, so at least Bitcoin Core wouldn’t start with such a config file.
  18. MarcoFalke referenced this in commit 5392aee64f on Apr 10, 2019
  19. MarcoFalke commented at 1:19 am on April 10, 2019: member
    Should be “fixed” in master
  20. MarcoFalke closed this on Apr 10, 2019
  21. vijaydasmp referenced this in commit 4082cef036 on Oct 15, 2021
  22. vijaydasmp referenced this in commit 0f74ebae16 on Oct 16, 2021
  23. vijaydasmp referenced this in commit 96f2c7d1d3 on Oct 16, 2021
  24. vijaydasmp referenced this in commit 01ec4b3fb6 on Oct 16, 2021
  25. vijaydasmp referenced this in commit 6d8217ed63 on Oct 16, 2021
  26. vijaydasmp referenced this in commit 95e5a21d1e on Oct 16, 2021
  27. vijaydasmp referenced this in commit ca0c5df7f0 on Oct 16, 2021
  28. MarcoFalke locked this on Dec 16, 2021


nikitasius ryanofsky MarcoFalke

Labels
Bug Utils/log/libs

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 12:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me