init: Throw error when network specific config is ignored #15629

pull MarcoFalke wants to merge 4 commits into bitcoin:master from MarcoFalke:1903-InitErrorConf changing 6 files +26 −17

MarcoFalke commented at 8:31 PM on March 20, 2019: member
This should have no effect on mainnet users, but simplifies testing, where config settings are currently ignored with only a warning. Fix this by making it an error.

Issues:
- bitcoin client 0.17.0 ignores wallet's name (file) #14523
- Can't set custom rpcport on testnet #13777
- ...
init: Throw error when network specific config is ignored dddd6f0f58
MarcoFalke added the label Tests on Mar 20, 2019
MarcoFalke added the label Utils/log/libs on Mar 20, 2019

promag commented at 2:59 PM on March 21, 2019: member

Tested ACK dddd6f0.

$ cat bitcoin.conf
rpcport=54321

bitcoind -testnet
2019-03-21T14:58:35Z Bitcoin Core version v0.18.99.0-dddd6f0f5 (release build)
2019-03-21T14:58:35Z Error: Config setting for -rpcport only applied on test network when in [test] section.
Error: Config setting for -rpcport only applied on test network when in [test] section.

Deserves a small release note, just to point to if someone reports this behavior change?

practicalswift commented at 3:06 PM on March 21, 2019: contributor

Concept ACK

Nice usability improvement!
promag commented at 7:40 PM on March 21, 2019: member

@MarcoFalke here's a test for your consideration 53469f780a8e2d88337f4efa6eb9ca52c9ce34f8.
MarcoFalke force-pushed on Mar 21, 2019
qa: Add test for missing testnet section in conf file fa4a922d78
doc: Add release notes for 15629 fa9058f0ed
MarcoFalke force-pushed on Mar 21, 2019
doc: Fix all typos reported by codespell fae38c3dc6

in doc/release-notes.md:80 in fa9058f0ed outdated

  72 | @@ -73,9 +73,14 @@ Example item
  73 |  Low-level changes
  74 |  =================
  75 |  
  76 | -Example item
  77 | +Configuration
  78 |  ------------
  79 |  
  80 | +* An error is issued where previously a warning was issued when a setting in
  81 | +  the config file was specified in the default section, but not overriden for

practicalswift commented at 8:11 AM on March 22, 2019:

Should be "overridden" :-)

DrahtBot commented at 11:30 PM on April 6, 2019: member



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

No conflicts as of last run.
MarcoFalke referenced this in commit 5392aee64f on Apr 10, 2019
MarcoFalke merged this on Apr 10, 2019
MarcoFalke closed this on Apr 10, 2019
MarcoFalke deleted the branch on Apr 10, 2019
promag commented at 1:27 AM on April 10, 2019: member

utACK fae38c3.
vijaydasmp referenced this in commit 4082cef036 on Oct 15, 2021
vijaydasmp referenced this in commit 0f74ebae16 on Oct 16, 2021
vijaydasmp referenced this in commit 96f2c7d1d3 on Oct 16, 2021
vijaydasmp referenced this in commit 01ec4b3fb6 on Oct 16, 2021
vijaydasmp referenced this in commit 6d8217ed63 on Oct 16, 2021
vijaydasmp referenced this in commit 95e5a21d1e on Oct 16, 2021
vijaydasmp referenced this in commit ca0c5df7f0 on Oct 16, 2021
vijaydasmp referenced this in commit 5df7adac26 on Oct 17, 2021
vijaydasmp referenced this in commit 68de6f2973 on Oct 19, 2021
PastaPastaPasta referenced this in commit 6e32a464f5 on Oct 21, 2021
pravblockc referenced this in commit 9876447066 on Nov 18, 2021
ftrader referenced this in commit 9b129ffa47 on Nov 21, 2021
ftrader referenced this in commit e553c9c36d on Nov 21, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#13777 Can't set custom rpcport on testnet #14523 bitcoin client 0.17.0 ignores wallet's name (file)#15636 Sporadic example_test.py failure

init: Throw error when network specific config is ignored #15629

Conflicts