bitcoin client 0.17.0 ignores wallet's name (file) #14523

Old config (version 0.15 and 0.16.0/0.16.3):

prune=8192
rpcuser=rpc
rpcpassword=rpc
onlynet=ipv4
testnet=1
rpcbind=127.0.0.1:18332
walletdir=/path/to/wallet/
wallet=mywallet.dat

It worked pretty nice.

UPD: it does not worked in version 0.17.0 ! BTC client made a new wallet.dat file

On version 0.17.0 i read what i can use full pathes to wallet files.

prune=8192
rpcuser=rpc
rpcpassword=rpc
onlynet=ipv4
testnet=1
rpcbind=127.0.0.1:18332
wallet=/path/to/wallet/mywallet.dat

FAILS. It created wallet.dat in /path/to/wallet/ folder

prune=8192
rpcuser=rpc
rpcpassword=rpc
onlynet=ipv4
testnet=1
rpcbind=127.0.0.1:18332
walletdir=/path/to/wallet/
wallet=/path/to/wallet/mywallet.dat

FAILS. It created wallet.dat in ~/.bitcoin/wallets folder.

Current config:

prune=8192
rpcuser=rpc
rpcpassword=rpc
onlynet=ipv4
testnet=1
rpcbind=127.0.0.1:18332
walletdir=/path/to/wallet/

AND i renamed mywallet.dat into wallet.dat to let client work.

I run bitcoin core client 0.17.0 on Linux 4.9.0-6-amd64 [#1](/bitcoin-bitcoin/1/) SMP Debian 4.9.88-1+deb9u1 (2018-05-07) x86_64 GNU/Linux.

walletdir=/path/to/wallet/ wallet=mywallet.dat It worked pretty nice. UPD: it does not worked in version 0.17.0 ! BTC client made a new wallet.dat file

I think I'm able to reproduce this. It looks like #11862 might be causing your wallet config argument to be ignored. Do you see this warning?

Warning: Config setting for -wallet only applied on test network when in [test] section.

On version 0.17.0 i read what i can use full pathes to wallet files.

We might need to clarify release notes, but this isn't true. You can only specify full paths to wallet directories not wallet files. (Originally this was possible, but it was deemed too dangerous because it might mislead people into creating incomplete backups of wallets).

@ryanofsky , hi yes:

grep applied debug.log
2018-10-19T21:04:04Z Warning: Config setting for -rpcbind only applied on test network when in [test] section.
2018-10-19T21:04:04Z Warning: Config setting for -wallet only applied on test network when in [test] section.
2018-10-19T21:16:02Z Warning: Config setting for -rpcbind only applied on test network when in [test] section.
2018-10-19T21:16:02Z Warning: Config setting for -wallet only applied on test network when in [test] section.
2018-10-19T21:21:35Z Warning: Config setting for -rpcbind only applied on test network when in [test] section.
2018-10-19T21:21:35Z Warning: Config setting for -wallet only applied on test network when in [test] section.
2018-10-19T21:23:35Z Warning: Config setting for -rpcbind only applied on test network when in [test] section.
2018-10-19T21:23:35Z Warning: Config setting for -wallet only applied on test network when in [test] section.
2018-10-19T21:30:02Z Warning: Config setting for -rpcbind only applied on test network when in [test] section.
2018-10-19T21:37:18Z Warning: Config setting for -rpcbind only applied on test network when in [test] section.
2018-10-19T21:37:18Z Warning: Config setting for -wallet only applied on test network when in [test] section.
2018-10-19T21:41:20Z Warning: Config setting for -rpcbind only applied on test network when in [test] section.

it's same debug.log i keep, records inside are from 14 october. 0.17.0 was installed yesterday.

but why i need (or not) to specity test section inside a config? i.e. i already specified a testnet.

but why i need (or not) to specity test section inside a config? i.e. i already specified a testnet.

Before #11862 and 0.17.0, you didn't need to have -wallet and other "network-only" options under a network section. Now it looks you need to or they get ignored.

I think this is a mistake, and we should backport a fix that will restore the old behavior. It don't think it is ok to just start ignoring settings that used to work. We should probably keep the log message to encourage people to use network-specific sections and be more explicit about settings that are sensitive to which network is used, but we should not just be dropping the settings on the floor.

It also seems like a mistake to me that -wallet is a "network-only" option but -walletdir is not. This is another thing that should probably be addressed.

Moving to 0.17.2

Made it an error instead of warning in #15629, so at least Bitcoin Core wouldn't start with such a config file.

Should be "fixed" in master