After merging #13622 the adjustedTime parameter in the updateStatus function is unused.
qt: Remove unused `adjustedTime` parameter #14554
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:20181023-unused-adjustedtime changing 7 files +12 −20-
hebasto commented at 2:45 PM on October 23, 2018: member
-
practicalswift commented at 2:54 PM on October 23, 2018: contributor
utACK cfc55edb6ae7bc49b4df38954fc434ffa831b78f
Nice find @hebasto! Thanks for cleaning this up.
- MarcoFalke added the label GUI on Oct 23, 2018
- MarcoFalke added the label Refactoring on Oct 23, 2018
-
DrahtBot commented at 9:59 PM on October 23, 2018: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #14556 (qt: Fix bug #13299 by hebasto)
- #14437 (Refactor: Start to separate wallet from node by ryanofsky)
- #10973 (Refactor: separate wallet from node by ryanofsky)
- #10102 ([experimental] Multiprocess bitcoin by ryanofsky)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
fanquake commented at 1:13 AM on October 24, 2018: member
Concept ACK, however it looks like the changes could be more comprehensive.
The remaining uses of
adjustedTimein/qt/are in:- FormatTxStatus
- getWalletTxDetails
- tryGetTxStatus
Of which, it looks like the usage of
adjustedTimein atleastFormatTxStatusis also redundant? -
hebasto commented at 4:00 AM on October 24, 2018: member
@practicalswift, @fanquake Thank you for your reviews. @fanquake's comment has been addressed. Please re-review.
-
fanquake commented at 3:01 AM on October 28, 2018: member
utACK 58fbed1
Can you squash 58fbed1 into cfc55ed, and prefix the commit message with
qt:, so that it's clear that these are qt/wallet changes. -
04972fefd1
Remove unused `adjustedTime` parameter
qt: After merging #13622 the `adjustedTime` is not used any more in wallet related functions.
- hebasto force-pushed on Oct 28, 2018
-
-
fanquake commented at 7:16 AM on October 28, 2018: member
re-utACK 04972fe
- ken2812221 approved
-
ken2812221 commented at 3:41 PM on October 28, 2018: contributor
utACK 04972fefd12c2c764b5f2afee87228e8d90f2448
- fanquake added this to the "Mergeable" column in a project
-
promag commented at 7:12 PM on November 4, 2018: member
utACK 04972fe.
- laanwj merged this on Nov 5, 2018
- laanwj closed this on Nov 5, 2018
- laanwj referenced this in commit 69d574ac6c on Nov 5, 2018
- fanquake removed this from the "Mergeable" column in a project
- hebasto deleted the branch on Nov 5, 2018
- Munkybooty referenced this in commit 947e131a36 on Jul 22, 2021
- Munkybooty referenced this in commit c97c5798ae on Jul 22, 2021
- Munkybooty referenced this in commit c0cbc650a3 on Jul 22, 2021
- Munkybooty referenced this in commit 92631e279e on Jul 22, 2021
- Munkybooty referenced this in commit 70c732ca03 on Jul 23, 2021
- Munkybooty referenced this in commit 0ffd51035f on Jul 23, 2021
- Munkybooty referenced this in commit 414e74ebca on Jul 23, 2021
- Munkybooty referenced this in commit 4fa5aefe85 on Jul 23, 2021
- Munkybooty referenced this in commit b31b607cc9 on Jul 26, 2021
- Munkybooty referenced this in commit fdf5563fb9 on Jul 27, 2021
- Munkybooty referenced this in commit ae6f3840c9 on Jul 28, 2021
- DrahtBot locked this on Sep 8, 2021
