appveyor: Enable multiwallet tests #14559

pull ken2812221 wants to merge 1 commits into bitcoin:master from ken2812221:appveyor-test-multiwallet changing 2 files +9 −14

ken2812221 commented at 7:13 AM on October 24, 2018: contributor

Based on #14320

This PR enable multiwallet test on appveyor. Also re-enable symlink tests on Windows which is available after Windows Vista.

I disable these tests in #13964 because I suppose that Windows does not support symlink, but I was wrong.
practicalswift commented at 7:30 AM on October 24, 2018: contributor

Concept ACK

Thanks for all your good appveyor work!
fanquake added the label Tests on Oct 24, 2018

in src/wallet/db.cpp:831 in 118f64736d outdated

 825 | @@ -826,6 +826,10 @@ void BerkeleyDatabase::Flush(bool shutdown)
 826 |              LOCK(cs_db);
 827 |              g_dbenvs.erase(env->Directory().string());
 828 |              env = nullptr;
 829 | +        } else {
 830 | +            // To avoid accessing a map that has already deconstructed, do not call this when shutdown is true. g_dbenvs.erase would also erase this value.
 831 | +            // TODO: get rid of wild pointers

practicalswift commented at 8:47 AM on October 24, 2018:

Wild pointers – scary stuff! Would you be able to construct a test case triggering that? What would it take to get rid of them?

ken2812221 commented at 9:17 AM on October 24, 2018:

@practicalswift This is the code from #14320. Better to move to here. It might can be resolved by #11911

in test/functional/wallet_multiwallet.py:147 in 118f64736d outdated

 142 | @@ -147,7 +143,7 @@ def wallet_file(name):
 143 |  
 144 |          self.restart_node(0, extra_args)
 145 |  
 146 | -        assert_equal(set(map(lambda w: w['name'], self.nodes[0].listwalletdir()['wallets'])), set(['', 'w3', 'w2', 'sub/w5', 'w7', 'w7', 'w8_copy', 'w1', 'w8', 'w']))
 147 | +        assert_equal(set(map(lambda w: w['name'], self.nodes[0].listwalletdir()['wallets'])), set(['', 'w3', 'w2', os.path.join('sub', 'w5'), 'w7', 'w7', 'w8_copy', 'w1', 'w8', 'w']))

promag commented at 8:48 AM on October 24, 2018:

In windows it is possible to set -wallet=sub/w5, listwallets gives sub/w5 but listwalletdir gives sub\w5?

ken2812221 commented at 9:38 AM on October 24, 2018:

Yes, unless we change to calling fs::path::generic_string() instead of calling fs::path::string()

ryanofsky approved
ryanofsky commented at 2:43 PM on October 24, 2018: member

utACK 118f64736dc9121ea9ce3159d64c66406f92bc13. Change is essentially the same as 02b6bd343da296dc29ea017447b18c9afa13b5e3 previously reviewed in #14320, except symlinks are allowed in some more cases in the multiwallet test.
ken2812221 force-pushed on Oct 24, 2018
ken2812221 commented at 3:14 PM on October 24, 2018: contributor

118f647 -> 216e8bf -> 4dca7d0a98d619c0aea572b181a7c5b95b2f62e5 Just rebase #14320
appveyor: Enable multiwallet test 4dca7d0a98
ken2812221 force-pushed on Oct 24, 2018
promag commented at 3:51 PM on October 24, 2018: member

utACK 4dca7d0.
MarcoFalke referenced this in commit 613fc95ee4 on Oct 24, 2018
MarcoFalke merged this on Oct 24, 2018
MarcoFalke closed this on Oct 24, 2018
ken2812221 deleted the branch on Oct 24, 2018
laanwj referenced this in commit d50c996a14 on Oct 26, 2018
deadalnix referenced this in commit f89fb96afc on Mar 24, 2020
ftrader referenced this in commit 046cf057dd on Aug 17, 2020
Munkybooty referenced this in commit 48dfb25f78 on Jul 21, 2021
5tefan referenced this in commit b7d97ccb2f on Aug 13, 2021
5tefan referenced this in commit a9858f167d on Aug 14, 2021
5tefan referenced this in commit 12d24c70f4 on Aug 14, 2021
5tefan referenced this in commit 4b2580102e on Aug 14, 2021
PastaPastaPasta referenced this in commit f370f41210 on Aug 16, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#13964 ci: Add Appveyor CI #14320 [bugfix] wallet: Fix duplicate fileid detection #14561 Remove fs::relative call and fix listwalletdir tests