Adjust configure so that only bip70 is disabled when protobuf is missing instead of the GUI #14564

pull jameshilliard wants to merge 1 commits into bitcoin:master from jameshilliard:bip70-disable-check changing 1 files +20 −10
  1. jameshilliard commented at 12:43 AM on October 25, 2018: contributor

    This change ensures that the GUI is still built even if protobuf is missing unless --enable-bip70 is passed to configure. If protobuf is present bip70 support will be compiled in unless --disable-bip70 is passed.

  2. fanquake added the label Build system on Oct 25, 2018
  3. fanquake added this to the milestone 0.18.0 on Oct 25, 2018
  4. Sjors commented at 3:53 AM on October 25, 2018: member

    tACK 3852aff on macOS 10.14

    With protobuf installed: <img width="281" alt="with protobuf" src="https://user-images.githubusercontent.com/10217/47474902-d73c4c00-d84b-11e8-8a46-1ac4a11bfbf5.png">

    Without protobuf installed: <img width="273" alt="without" src="https://user-images.githubusercontent.com/10217/47474946-0652bd80-d84c-11e8-9a07-c125d6a7fa09.png">

    Without protobuf installed, with --enable-bip70: <img width="628" alt="schermafbeelding 2018-10-25 om 11 53 26" src="https://user-images.githubusercontent.com/10217/47475070-9c86e380-d84c-11e8-9555-6daf42fc370f.png">

    (when checking out this branch for the first time, you need a make (dist?)clean in order to see the bip70 configure option)

  5. jameshilliard commented at 3:58 AM on October 25, 2018: contributor

    I think ./autogen.sh will also get you the configure option.

  6. fanquake commented at 3:55 AM on October 26, 2018: member

    testing 3852aff:

    with protobuf and ./configure:

    with gui / qt = yes
  with bip70  = yes
  with qr     = yes
with zmq      = yes

    with protobuf and ./configure --disable-bip70:

    with gui / qt = yes
  with bip70  = no
  with qr     = yes
with zmq      = yes

    without protobuf and ./configure:

    with gui / qt = yes
  with bip70  = no
  with qr     = yes
with zmq      = yes

    without protobuf and ./configure --enable-bip70:

    checking whether to build test_bitcoin-qt... yes
checking whether to build BIP70 support... configure: error: protobuf missing
  7. MarcoFalke added the label Needs gitian build on Oct 26, 2018
  8. DrahtBot commented at 4:53 AM on October 27, 2018: member

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds for commit f4e4ea1ceecfb978584bd4f43cb6826e44ba86a3 (master):

    Gitian builds for commit 5d78c857f3117cacaea4275b474c164e3e88bbd2 (master and this pull):

  9. DrahtBot removed the label Needs gitian build on Oct 27, 2018
  10. MarcoFalke commented at 11:00 AM on October 27, 2018: member

    Gitian fails with

      CXXLD    test/test_bitcoin.exe
  GEN      qt/forms/ui_addressbookpage.h
  GEN      qt/forms/ui_askpassphrasedialog.h
  GEN      qt/forms/ui_coincontroldialog.h
  GEN      qt/forms/ui_editaddressdialog.h
  GEN      qt/forms/ui_helpmessagedialog.h
  GEN      qt/forms/ui_intro.h
  GEN      qt/forms/ui_modaloverlay.h
  GEN      qt/forms/ui_openuridialog.h
  GEN      qt/forms/ui_optionsdialog.h
  GEN      qt/forms/ui_overviewpage.h
  GEN      qt/forms/ui_receivecoinsdialog.h
  GEN      qt/forms/ui_receiverequestdialog.h
  GEN      qt/forms/ui_debugwindow.h
  GEN      qt/forms/ui_sendcoinsdialog.h
  GEN      qt/forms/ui_sendcoinsentry.h
  GEN      qt/forms/ui_signverifymessagedialog.h
  GEN      qt/forms/ui_transactiondescdialog.h
  GEN      qt/paymentrequest.pb.h
/bin/bash: --cpp_out=qt: command not found
Makefile:10790: recipe for target 'qt/paymentrequest.pb.h' failed
make[2]: *** [qt/paymentrequest.pb.h] Error 127
make[2]: Leaving directory '/home/ubuntu/build/bitcoin/distsrc-i686-w64-mingw32/src'
Makefile:10248: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/home/ubuntu/build/bitcoin/distsrc-i686-w64-mingw32/src'
Makefile:774: recipe for target 'all-recursive' failed
make: *** [all-recursive] Error 1
  11. MarcoFalke closed this on Oct 27, 2018
  12. MarcoFalke reopened this on Oct 27, 2018
  13. MarcoFalke commented at 11:25 AM on October 27, 2018: member

    Travis failure:

    In file included from ./qt/paymentserver.h:40:0,
                 from qt/bitcoin.cpp:25:
./qt/paymentrequestplus.h:10:10: fatal error: qt/paymentrequest.pb.h: No such file or directory
 #include <qt/paymentrequest.pb.h>
          ^~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
Makefile:8804: recipe for target 'qt/qt_bitcoin_qt-bitcoin.o' failed
make[2]: *** [qt/qt_bitcoin_qt-bitcoin.o] Error 1
make[2]: Leaving directory '/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-w64-mingw32/src'
Makefile:10248: recipe for target 'all-recursive' failed
make[1]: Leaving directory '/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-w64-mingw32/src'
make[1]: *** [all-recursive] Error 1
make: *** [all-recursive] Error 1
Makefile:774: recipe for target 'all-recursive' failed
  14. jameshilliard commented at 7:27 PM on October 27, 2018: contributor

    @ken2812221 does this seem to be a similar issue to #14568?

  15. DrahtBot commented at 11:54 PM on November 1, 2018: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #10102 ([experimental] Multiprocess bitcoin by ryanofsky)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  16. jameshilliard force-pushed on Nov 10, 2018
  17. Adjust configure so that only bip70 is disabled when protobuf is missing instead of the GUI 58c5cc9ce7
  18. jameshilliard force-pushed on Nov 10, 2018
  19. in configure.ac:1233 in 58c5cc9ce7 
    1228 | @@ -1229,8 +1229,10 @@ AM_CONDITIONAL([EMBEDDED_UNIVALUE],[test x$need_bundled_univalue = xyes])
1229 |  AC_SUBST(UNIVALUE_CFLAGS)
1230 |  AC_SUBST(UNIVALUE_LIBS)
1231 |  
1232 | -if test x$enable_bip70 != xno; then
1233 | -BITCOIN_QT_PATH_PROGS([PROTOC], [protoc],$protoc_bin_path)
1234 | +
1235 | +if test x$have_protobuf != xno &&
    jameshilliard commented at 10:00 PM on November 10, 2018:

    I changed this from test x$have_protobuf = xyes which fixes builds without pkg-config since have_protobuf=yes is not set when protobuf is present on non-pkg-config builds.

  20. jameshilliard commented at 10:35 PM on November 10, 2018: contributor

    This should be fixed now, can we trigger a new gitian test build?

  21. MarcoFalke added the label Needs gitian build on Nov 11, 2018
  22. DrahtBot commented at 6:12 AM on November 12, 2018: member

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds for commit edc715240cb6738262ae96dea476544052eb5351 (master):

    Gitian builds for commit 8ba6b08d0066e507298f5f1f2261d2f7ffd0e588 (master and this pull):

  23. DrahtBot removed the label Needs gitian build on Nov 12, 2018
  24. gmaxwell commented at 7:35 PM on November 21, 2018: contributor

    utACK

  25. MarcoFalke merged this on Dec 6, 2018
  26. MarcoFalke closed this on Dec 6, 2018
  27. MarcoFalke referenced this in commit 23a1fa0248 on Dec 6, 2018
  28. luke-jr referenced this in commit f18325304b on Dec 21, 2018
  29. luke-jr referenced this in commit 292362856b on Dec 24, 2018
  30. dzutto referenced this in commit 360a0dd854 on Aug 18, 2021
  31. dzutto referenced this in commit f3407c73c3 on Aug 19, 2021
  32. dzutto referenced this in commit 396c16e85b on Aug 19, 2021
  33. dzutto referenced this in commit 1563480000 on Aug 23, 2021
  34. dzutto referenced this in commit 15e367a1c0 on Aug 26, 2021
  35. dzutto referenced this in commit d073a176f4 on Aug 26, 2021
  36. dzutto referenced this in commit 58e9b9cc4d on Aug 27, 2021
  37. PastaPastaPasta referenced this in commit b9df9815ba on Aug 29, 2021
  38. DrahtBot locked this on Sep 8, 2021
Contributors
jameshilliardSjorsfanquakeDrahtBotMarcoFalkegmaxwell
Labels
Build system

Milestone
0.18.0

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 21:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me