build: Remove illegal spacing in darwin.mk #14647

1. 
   ch4ot1c commented at 10:06 AM on November 3, 2018: contributor

   MacOS 10.13.6, make -v = GNU Make 4.2.1 Built for x86_64-apple-darwin17.7.0

   cd depends
   make HOST=x86_64-apple-darwin17.7.0
   

   Results in error:

   builders/darwin.mk:1: *** empty variable name.  Stop.
   

   This seems to fix it.

2. build: Remove illegal spacing in darwin.mk 63c74d2d3a
3. fanquake added the label Build system on Nov 3, 2018
4. MarcoFalke added the label macOS on Nov 3, 2018
5. 
   DrahtBot commented at 3:12 PM on November 3, 2018: member

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   No conflicts as of last run.

6. 
   fanquake commented at 10:23 AM on November 5, 2018: member

   tACK 63c74d2

   So depends works fine with the macOS make (GNU Make 3.81, built for i386-apple-darwin11.3.0).

   However a brew installed make (GNU Make 4.2.1, built for x86_64-apple-darwin18.0.0), which isgmake here, does not work.

   I assume backward-incompatible changes from 3.82 or 4.0 are the problem.

   master (b740788):

   cd depends
   gmake --version
   GNU Make 4.2.1
   
   $ gmake -j6
   builders/darwin.mk:1: *** empty variable name.  Stop.
   

   This PR (63c74d2), using NO_QT=1 because building qt with newer make is broken, see #14648:

   cd depends
   gmake NO_QT=1 -j6
   .....
   Caching miniupnpc...
   copying packages: native_biplist native_ds_store native_mac_alias boost openssl libevent zeromq bdb miniupnpc
   to: /Users/michael/github/bitcoin/depends/x86_64-apple-darwin18.2.0
   

7. 
   laanwj commented at 10:44 AM on November 5, 2018: member

   utACK 63c74d2d3abcb685c773c3ad1414da6ad062a55d, I do not understand why this fixes anything, but will just go with @fanquake's tACK here

8. laanwj merged this on Nov 5, 2018
9. laanwj closed this on Nov 5, 2018

   ---

10. laanwj referenced this in commit 13d98ea0d7 on Nov 5, 2018
11. 
    gmaxwell commented at 3:31 AM on November 20, 2018: contributor

    Backport me?

12. fanquake added the label Needs backport on Nov 20, 2018
13. MarcoFalke added this to the milestone 0.17.1 on Nov 20, 2018
14. MarcoFalke referenced this in commit 41926dce76 on Nov 20, 2018
15. MarcoFalke referenced this in commit 7edebedef1 on Nov 28, 2018
16. MarcoFalke removed the label Needs backport on Nov 28, 2018
17. deadalnix referenced this in commit cef0b6a205 on Mar 31, 2020
18. ftrader referenced this in commit 8f8654fd40 on Aug 17, 2020
19. UdjinM6 referenced this in commit 7bb0c1429d on Dec 17, 2020
20. PastaPastaPasta referenced this in commit e481d2ca49 on Jul 17, 2021
21. MarcoFalke locked this on Sep 8, 2021

Milestone
0.17.1