[doc] conf: Remove deprecated options from docs, Other cleanup #14684

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1609-trivialPre14 changing 4 files +12 −14
  1. MarcoFalke commented at 5:42 PM on November 7, 2018: member

    Some dumb fixes, like removing the mention that free transactions are still a thing or that rpcuser/pass should be used (as opposed to rpcauth or rpc cookie).

    Combined with other fixes because I don't want to create 3 pull requests:

    • conf: Remove deprecated options from docs
    • Remove only mention of MIT/X11
    • Link to developer notes in README.md
  2. MarcoFalke added the label Docs on Nov 7, 2018
  3. in doc/build-osx.md:83 in fac57360d0 outdated
      79 | @@ -80,9 +80,9 @@ Running
      80 |  
      81 |  Bitcoin Core is now available at `./src/bitcoind`
      82 |  
      83 | -Before running, it's recommended that you create an RPC configuration file:
      84 | +Before running, you may create an RPC configuration file:
    


    practicalswift commented at 5:54 PM on November 7, 2018:

    No longer a RPC configuration file if empty? :-)

  4. in doc/build-osx.md:85 in fac57360d0 outdated
      79 | @@ -80,9 +80,9 @@ Running
      80 |  
      81 |  Bitcoin Core is now available at `./src/bitcoind`
      82 |  
      83 | -Before running, it's recommended that you create an RPC configuration file:
      84 | +Before running, you may create an RPC configuration file:
      85 |  
      86 | -    echo -e "rpcuser=bitcoinrpc\nrpcpassword=$(xxd -l 16 -p /dev/urandom)" > "/Users/${USER}/Library/Application Support/Bitcoin/bitcoin.conf"
      87 | +    echo > "/Users/${USER}/Library/Application Support/Bitcoin/bitcoin.conf"
    


    practicalswift commented at 5:55 PM on November 7, 2018:

    Use touch "/Users/${USER}/Library/Application Support/Bitcoin/bitcoin.conf" to create an empty file

  5. in share/examples/bitcoin.conf:74 in fac57360d0 outdated
      70 | @@ -71,12 +71,9 @@
      71 |  # is .cookie and found in the `-datadir` being used for bitcoind. This option is typically used
      72 |  # when the server and client are run as the same user.
      73 |  #
      74 | -# If not, you must set rpcuser and rpcpassword to secure the JSON-RPC api. The first
      75 | -# method(DEPRECATED) is to set this pair for the server and client:
      76 | -#rpcuser=Ulysseys
      77 | -#rpcpassword=YourSuperGreatPasswordNumber_DO_NOT_USE_THIS_OR_YOU_WILL_GET_ROBBED_385593
      78 | +# If not, you must set rpcuser and rpcpassword to secure the JSON-RPC api.
    


    practicalswift commented at 5:56 PM on November 7, 2018:

    Uppercase API :-)

  6. practicalswift commented at 5:56 PM on November 7, 2018: contributor

    utACK fac57360d0f1375d8df34c57063d83e30cb5499f modulo nits :-)

  7. MarcoFalke force-pushed on Nov 7, 2018
  8. [doc] conf: Remove deprecated options from docs, Other cleanup
    * conf: Remove deprecated options from docs
    * Remove only mention of MIT/X11
    * Link to developer notes in README.md
    fa4da3c058
  9. in doc/build-osx.md:83 in fa21d73914 outdated
      79 | @@ -80,9 +80,9 @@ Running
      80 |  
      81 |  Bitcoin Core is now available at `./src/bitcoind`
      82 |  
      83 | -Before running, it's recommended that you create an RPC configuration file:
      84 | +Before running, you may create an empty RPC configuration file:
    


    practicalswift commented at 6:21 PM on November 7, 2018:

    Do we generally refer to bitcoin.conf as "configuration file" or "RPC configuration file"?

  10. MarcoFalke force-pushed on Nov 7, 2018
  11. DrahtBot commented at 8:26 PM on November 7, 2018: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    No conflicts as of last run.

  12. practicalswift commented at 8:30 PM on November 7, 2018: contributor

    ACK fa4da3c0588244e13bad66a84e1393fdf4735a81

  13. fanquake commented at 7:55 AM on November 8, 2018: member

    utACK fa4da3c

  14. hebasto commented at 9:01 AM on November 8, 2018: member

    utACK fa4da3c0588244e13bad66a84e1393fdf4735a81

  15. promag commented at 10:13 AM on November 8, 2018: member

    utACK fa4da3c.

  16. MarcoFalke merged this on Nov 8, 2018
  17. MarcoFalke closed this on Nov 8, 2018

  18. MarcoFalke referenced this in commit e70a19e713 on Nov 8, 2018
  19. MarcoFalke deleted the branch on Nov 8, 2018
  20. Munkybooty referenced this in commit 0e1062315b on Jul 29, 2021
  21. Munkybooty referenced this in commit e1e36309bf on Aug 3, 2021
  22. 5tefan referenced this in commit 20963d38f4 on Aug 12, 2021
  23. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 06:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me