Throw error if CPubKey is invalid during PSBT keypath serialization #14690

pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:check_psbt_pubkey changing 1 files +3 −0

instagibbs commented at 3:34 PM on November 8, 2018: member

Related to #14689

We should catch this error before attempting to deserialize it later.
Throw error if CPubKey is invalid during PSBT keypath serialization 4e4de10f69
instagibbs force-pushed on Nov 8, 2018
Sjors commented at 4:40 PM on November 8, 2018: member

This catches the downstream issue I was seeing during the createfundedpsbt call rather than during decodepsbt.
DrahtBot commented at 5:09 PM on November 8, 2018: member



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

No conflicts as of last run.

Coverage

Coverage Change (pull 14690) Reference (master)

Lines +0.0022 % 87.0730 %

Functions -0.0306 % 84.3717 %

Branches +0.0038 % 51.5638 %

<sup>Updated at: 2018-11-08T22:18:32.440618.</sup>
meshcollider added the label Wallet on Nov 8, 2018
meshcollider commented at 9:51 PM on November 8, 2018: contributor

utACK https://github.com/bitcoin/bitcoin/pull/14690/commits/4e4de10f69d5d705256cadfb15d76314dff16e77
sipa commented at 4:15 AM on November 10, 2018: member

utACK 4e4de10f69d5d705256cadfb15d76314dff16e77
promag commented at 7:33 PM on November 12, 2018: member

utACK 4e4de10.
laanwj merged this on Nov 13, 2018
laanwj closed this on Nov 13, 2018
laanwj referenced this in commit ce7fcc3569 on Nov 13, 2018
gmaxwell commented at 12:37 AM on November 20, 2018: contributor

Backport?
sipa added the label Needs backport on Nov 22, 2018
sipa commented at 1:06 AM on November 22, 2018: member

Marked for backport.
fanquake referenced this in commit 5782fdcd8c on Nov 29, 2018
fanquake commented at 4:34 AM on November 29, 2018: member

Backported in #14835.
fanquake removed the label Needs backport on Nov 29, 2018
MarcoFalke referenced this in commit d8bc0ce1da on Nov 30, 2018
deadalnix referenced this in commit d59cda9c1b on May 11, 2020
knst referenced this in commit 79266d56af on Aug 10, 2021
knst referenced this in commit d60446f198 on Aug 10, 2021
knst referenced this in commit cd4f4ec60f on Aug 16, 2021
PastaPastaPasta referenced this in commit 739c675f03 on Aug 23, 2021
UdjinM6 referenced this in commit f38aa44bfd on Aug 29, 2021
MarcoFalke locked this on Sep 8, 2021