Drop defunct prevector compat handling #14715

pull Empact wants to merge 2 commits into bitcoin:master from Empact:trivial-prevector changing 3 files +10 −18

Empact commented at 9:30 AM on November 13, 2018: member
This is clean-up post #14651:
- Use one implementation of prevector::fill, as it's possible now that the implementations are identical.
- Only apply the IS_TRIVIALLY_CONSTRUCTIBLE handling to the bench file where it is used, and drop the now-unnecessary associated compat includes.
fanquake added the label Refactoring on Nov 13, 2018
practicalswift commented at 10:19 AM on November 13, 2018: contributor

Concept ACK
in src/compat.h:13 in 1af24ffba8 outdated
```
   9 | @@ -10,16 +10,6 @@
  10 |  #include <config/bitcoin-config.h>
  11 |  #endif
  12 |  
  13 | -#include <type_traits>
```
promag commented at 2:04 PM on November 13, 2018:

Should include in bench? https://en.cppreference.com/w/cpp/types/is_default_constructible
promag commented at 2:06 PM on November 13, 2018: member

LGTM
laanwj commented at 3:52 PM on November 13, 2018: member

concept ACK
Empact force-pushed on Nov 13, 2018
in src/bench/prevector.cpp:11 in c94dd91ecd outdated
```
   7 |  #include <serialize.h>
   8 |  #include <streams.h>
   9 |  
  10 |  #include <bench/bench.h>
  11 |  
  12 | +#include <type_traits>
```
laanwj commented at 10:46 AM on November 14, 2018:

please group this with the other system includes at the top

Drop defunct IS_TRIVIALLY_CONSTRUCTIBLE handling from prevector.h

It's now only referenced from the bench, so leave it there. This allows us to
drop the associated includes as well.

7bad78c2c8

Implement prevector::fill once

Now that the implementation is identical, we can use a default value to
distinguish them.

69ca48717c

Empact force-pushed on Nov 14, 2018
sipa commented at 12:20 AM on November 15, 2018: member

utACK 69ca48717ceb31e37e90276278362c809cf98cc6
MarcoFalke commented at 10:05 PM on November 15, 2018: member

utACK 69ca48717ceb31e37e90276278362c809cf98cc6
promag commented at 10:16 PM on November 15, 2018: member

utACK 69ca487.
practicalswift commented at 10:23 PM on November 15, 2018: contributor

utACK 69ca48717ceb31e37e90276278362c809cf98cc6
laanwj commented at 9:50 AM on November 22, 2018: member

utACK 69ca48717ceb31e37e90276278362c809cf98cc6
laanwj merged this on Nov 22, 2018
laanwj closed this on Nov 22, 2018
laanwj referenced this in commit e736b67467 on Nov 22, 2018
Empact deleted the branch on Nov 22, 2018
furszy referenced this in commit 95ed10a37e on Dec 20, 2020
PastaPastaPasta referenced this in commit 71a9769e3d on Jun 27, 2021
PastaPastaPasta referenced this in commit c40dc4e674 on Jun 28, 2021
PastaPastaPasta referenced this in commit 906e78c3b9 on Jun 29, 2021
Munkybooty referenced this in commit c417eaef50 on Jul 29, 2021
MarcoFalke locked this on Sep 8, 2021
christiancfifi referenced this in commit 3b9d0f9e6b on Oct 3, 2021
christiancfifi referenced this in commit 0523f8d74e on Oct 4, 2021

Contributors

Labels