practicalswift
commented at 8:12 PM on November 13, 2018:
contributor
Concept ACK
Nice cleanup!
laanwj
commented at 8:30 PM on November 13, 2018:
member
Makes sense, though I guess the idea eventually would be to use the just-merged RPCHelpMan here?
The tests should pass with or without the changes in src.
Might make sense to split them out to a commit that goes in before the src changes to make this clear.
MarcoFalke
commented at 8:36 PM on November 13, 2018:
member
By splitting it up, the changes are easier to potentially backport and also make review easier when we switch to RPCHelpMan.
MarcoFalke added the label Docs on Nov 13, 2018
MarcoFalke added the label RPC/REST/ZMQ on Nov 13, 2018
DrahtBot
commented at 9:41 PM on November 13, 2018:
member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
#14411 ([wallet] Restore ability to list incoming transactions by label by ryanofsky)
#13756 (wallet: "avoid_reuse" wallet flag for improved privacy by kallewoof)
#12674 (RPC: Support addnode onetry without making the connection priviliged by luke-jr)
#10593 (Relax punishment for peers relaying invalid blocks and headers by luke-jr)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
ryanofsky approved
ryanofsky
commented at 9:43 PM on November 13, 2018:
member
utACKfa0815c3005c861ba94b96412e7997c25e7f6788
MarcoFalke merged this on Nov 13, 2018
MarcoFalke closed this on Nov 13, 2018
MarcoFalke referenced this in commit 8c59bb85f9 on Nov 13, 2018
MarcoFalke deleted the branch on Nov 13, 2018
deadalnix referenced this in commit 054899250f on Feb 13, 2020
Munkybooty referenced this in commit 9449010b93 on Jul 29, 2021
Munkybooty referenced this in commit 5cf0ca25d3 on Aug 3, 2021
Munkybooty referenced this in commit cb2d12464b on Aug 5, 2021
Munkybooty referenced this in commit fdc859037d on Aug 8, 2021
Munkybooty referenced this in commit 088a3cab0a on Aug 9, 2021
Munkybooty referenced this in commit 0fd490ff28 on Aug 11, 2021
5tefan referenced this in commit eefcb5fb62 on Aug 12, 2021
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:15 UTC
This site is hosted by @0xB10C More mirrored repositories can be found on mirror.b10c.me