rpc: Correctly name arguments #14720

1. 
   MarcoFalke commented at 7:19 pm on November 13, 2018: member

   Consistently use the same name to describe arguments in the documentation and add a test that uses the name.

   By splitting it up, the changes are easier to potentially backport and also make review easier when we switch to RPCHelpMan.

   The tests should pass with or without the changes in src.

   Partly stolen from #14459 (More RPC help description fixes by ch4ot1c)

2. 
   MarcoFalke commented at 7:19 pm on November 13, 2018: member

   cc @ch4ot1c
3. MarcoFalke force-pushed on Nov 13, 2018
4. rpc: Correctly name arguments fa0815c300
5. MarcoFalke force-pushed on Nov 13, 2018
6. 
   meshcollider commented at 7:54 pm on November 13, 2018: contributor

   utACK https://github.com/bitcoin/bitcoin/pull/14720/commits/fa0815c3005c861ba94b96412e7997c25e7f6788
7. 
   practicalswift commented at 8:12 pm on November 13, 2018: contributor

   Concept ACK

   Nice cleanup!

8. 
   laanwj commented at 8:30 pm on November 13, 2018: member

   Makes sense, though I guess the idea eventually would be to use the just-merged RPCHelpMan here?

   The tests should pass with or without the changes in src.

   Might make sense to split them out to a commit that goes in before the src changes to make this clear.

9. 
   MarcoFalke commented at 8:36 pm on November 13, 2018: member

   By splitting it up, the changes are easier to potentially backport and also make review easier when we switch to RPCHelpMan.
10. MarcoFalke added the label Docs on Nov 13, 2018
11. MarcoFalke added the label RPC/REST/ZMQ on Nov 13, 2018
12. 
    DrahtBot commented at 9:41 pm on November 13, 2018: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #14411 ([wallet] Restore ability to list incoming transactions by label by ryanofsky)
    • #13756 (wallet: “avoid_reuse” wallet flag for improved privacy by kallewoof)
    • #12674 (RPC: Support addnode onetry without making the connection priviliged by luke-jr)
    • #10593 (Relax punishment for peers relaying invalid blocks and headers by luke-jr)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

13. ryanofsky approved
14. 
    ryanofsky commented at 9:43 pm on November 13, 2018: member

    utACK fa0815c3005c861ba94b96412e7997c25e7f6788
15. MarcoFalke merged this on Nov 13, 2018
16. MarcoFalke closed this on Nov 13, 2018

    ---

17. MarcoFalke referenced this in commit 8c59bb85f9 on Nov 13, 2018
18. MarcoFalke deleted the branch on Nov 13, 2018
19. deadalnix referenced this in commit 054899250f on Feb 13, 2020
20. Munkybooty referenced this in commit 9449010b93 on Jul 29, 2021
21. Munkybooty referenced this in commit 5cf0ca25d3 on Aug 3, 2021
22. Munkybooty referenced this in commit cb2d12464b on Aug 5, 2021
23. Munkybooty referenced this in commit fdc859037d on Aug 8, 2021
24. Munkybooty referenced this in commit 088a3cab0a on Aug 9, 2021
25. Munkybooty referenced this in commit 0fd490ff28 on Aug 11, 2021
26. 5tefan referenced this in commit eefcb5fb62 on Aug 12, 2021
27. DrahtBot locked this on Sep 8, 2021

Contributors
MarcoFalke meshcollider practicalswift laanwj DrahtBot ryanofsky

Labels
Docs RPC/REST/ZMQ