qt: Use window() instead of obsolete topLevelWidget() #14801

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:20181125-obsolete-toplevelwidget changing 1 files +1 −1
  1. hebasto commented at 9:48 AM on November 25, 2018: member
  2. Use window() instead of obsolete topLevelWidget() 0b4a5786bb
  3. fanquake added the label GUI on Nov 25, 2018
  4. practicalswift commented at 11:34 PM on November 25, 2018: contributor

    Concept ACK

  5. fanquake commented at 12:56 AM on November 26, 2018: member

    utACK 0b4a578

    Looking at qwidget.h in depends (5.9.6):

    QWidget *window() const;
    QWidget *nativeParentWidget() const;
    inline QWidget *topLevelWidget() const { return window(); }
    

    Also checked that there are no more usages of topLevelWidget in the code base.

  6. MarcoFalke added this to the milestone 0.18.0 on Nov 26, 2018
  7. MarcoFalke added the label Refactoring on Nov 26, 2018
  8. promag commented at 3:06 PM on November 27, 2018: member

    ACK 0b4a578.

  9. ken2812221 commented at 8:00 AM on November 30, 2018: contributor

    tACK 0b4a5786bb5442a309c22e534e62ab1082588300

  10. laanwj merged this on Dec 9, 2018
  11. laanwj closed this on Dec 9, 2018

  12. laanwj referenced this in commit 0eb65aa902 on Dec 9, 2018
  13. hebasto deleted the branch on Dec 9, 2018
  14. jasonbcox referenced this in commit f898535231 on Sep 30, 2020
  15. TheArbitrator referenced this in commit 504f1579ba on Jun 23, 2021
  16. barton2526 referenced this in commit 9522d7bccb on Jun 23, 2021
  17. PastaPastaPasta referenced this in commit 660fc0b56f on Jun 27, 2021
  18. PastaPastaPasta referenced this in commit 37d2277d2d on Jun 28, 2021
  19. PastaPastaPasta referenced this in commit 07528e4a8c on Jun 29, 2021
  20. PastaPastaPasta referenced this in commit 917ae1c25e on Jul 1, 2021
  21. PastaPastaPasta referenced this in commit 88f6133de0 on Jul 1, 2021
  22. PastaPastaPasta referenced this in commit 6a55a44ee1 on Jul 1, 2021
  23. UdjinM6 referenced this in commit 31e35c8e8e on Jul 5, 2021
  24. furszy referenced this in commit 92bea4034e on Jul 6, 2021
  25. PastaPastaPasta referenced this in commit 221ff4223d on Jul 8, 2021
  26. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me