Calling getblocktemplate without the segwit rule specified is most likely a client error, since it results in lower fees for the miner. Prevent this client error by failing getblocktemplate if called without the segwit rule specified.
Of the previous 1000 blocks (measured at block 551591 (hash 0x…173c811)), 991 included segwit transactions.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
Is there a reason to not make it implicit and optionally return a warning?
Otherwise could update getblocktemplate description to mention that template_request.rules is not optional, at least be {"rules":["segwit"]}?
Suggest adding a “Mining” section to the release notes
Done
64@@ -65,6 +65,13 @@ platform.
65 Notable changes
66 ===============
67
68+Mining
69+------
70+
71+- Calls to `getblocktemplate` will fail if the segwit rule is not specified.
72+ Calling `getblocktemplate` without segwit specified is almost certainly
73+ a misconfiguration since doing so results in lower fees for the miner.
Lower fees sounds like a good thing.
0 a misconfiguration since doing so results in lower rewards for the miner.
188@@ -182,6 +189,8 @@ in the Low-level Changes section below.
189 P2SH-P2WPKH, and P2SH-P2WSH. Requests for P2WSH and P2SH-P2WSH accept
190 an additional `witnessscript` parameter.
191
192+- See the *Mining* section for changes to `getblocktemplate`.
See the [Mining](#mining) ....
528@@ -529,21 +529,17 @@ static UniValue getblocktemplate(const JSONRPCRequest& request)
529 }
530
531 const struct VBDeploymentInfo& segwit_info = VersionBitsDeploymentInfo[Consensus::DEPLOYMENT_SEGWIT];
532- // If the caller is indicating segwit support, then allow CreateNewBlock()
533- // to select witness transactions, after segwit activates (otherwise
534- // don't).
535- bool fSupportsSegwit = setClientRules.find(segwit_info.name) != setClientRules.end();
536+ // GBT must be called with 'segwit' set in the rules
537+ if (setClientRules.find(segwit_info.name) == setClientRules.end()) {
count() instead of find()?
Calling getblocktemplate without the segwit rule specified is most
likely a client error, since it results in lower fees for the miner.
Prevent this client error by failing getblocktemplate if called without
the segwit rule specified.
GBT must now be called with the segwit rule.
533- // to select witness transactions, after segwit activates (otherwise
534- // don't).
535- bool fSupportsSegwit = setClientRules.find(segwit_info.name) != setClientRules.end();
536+ // GBT must be called with 'segwit' set in the rules
537+ if (setClientRules.count(segwit_info.name) != 1) {
538+ throw JSONRPCError(RPC_INVALID_PARAMETER, "getblocktemplate must be called with the segwit rule set (call with {\"rules\": [\"segwit\"]})");