This should destroy the wallet txs when the benchmark ends to avoid having to hold them when the following benchmarks run.
bench: Destroy wallet txs instead of leaking their memory #14822
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1811-benchWalletTxs changing 2 files +15 −18-
MarcoFalke commented at 9:55 PM on November 27, 2018: member
-
bench: Destroy wallet txs instead of leaking their memory fa5cef0f78
- MarcoFalke added the label Refactoring on Nov 27, 2018
- MarcoFalke added the label Tests on Nov 27, 2018
- MarcoFalke requested review from kallewoof on Nov 27, 2018
-
practicalswift commented at 10:21 PM on November 27, 2018: contributor
Concept ACK
Thanks for doing this. Nice to get rid of the need for suppressions for this leak in LSAN, Valgrind, etc.
- kallewoof approved
-
kallewoof commented at 1:40 AM on November 28, 2018: member
utACK fa5cef0f785705474251faa4b5bf0f94c7100420
LGTM!
- ken2812221 approved
-
ken2812221 commented at 3:59 AM on November 28, 2018: contributor
utACK fa5cef0f785705474251faa4b5bf0f94c7100420
-
gmaxwell commented at 4:44 AM on November 28, 2018: contributor
utACK.
-
meshcollider commented at 6:01 AM on November 28, 2018: contributor
-
promag commented at 9:45 AM on November 28, 2018: member
utACK fa5cef0.
- MarcoFalke merged this on Nov 28, 2018
- MarcoFalke closed this on Nov 28, 2018
- MarcoFalke referenced this in commit 60b20c869f on Nov 28, 2018
- MarcoFalke deleted the branch on Nov 28, 2018
- DrahtBot locked this on Sep 8, 2021
