[0.17] Further Backports #14835

1. 
   fanquake commented at 4:33 AM on November 29, 2018: member

   Backports #14593, #14596, #14618, #14690 and #14728 to the 0.17 branch.

2. gui: explicitly disable "Dark Mode" appearance on macOS

   Github-Pull: #14593
   Rebased-From: cf2f4306fe26305b24bba8833af845ada3a42ec8

   df5131bd41
3. Bugfix: RPC: Add address_type named param for createmultisig

   Github-Pull: #14596
   Rebased-From: d8bf1071cf819fb4e848bb832af8199f084e0434

   de5e48a461
4. Throw error if CPubKey is invalid during PSBT keypath serialization

   Github-Pull: #14690
   Rebased-From: 4e4de10f69d5d705256cadfb15d76314dff16e77

   5782fdcd8c
5. fanquake added the label Backport on Nov 29, 2018
6. fanquake added this to the milestone 0.17.1 on Nov 29, 2018
7. fix uninitialized read when stringifying an addrLocal

   Reachable from either place where SetIP is used when our best-guess
   addrLocal for a peer is IPv4, but the peer tells us it's reaching us at
   an IPv6 address.
   
   In that case, SetIP turns an IPv4 address into an IPv6 address without
   setting the scopeId, which is subsequently read in GetSockAddr during
   CNetAddr::ToStringIP and passed to getnameinfo. Fix by ensuring every
   constructor initializes the scopeId field with something.
   
   Github-Pull: #14728
   Rebased-From: b7b36decaf878a8c1dcfdb4a27196c730043474b

   6f04264bbb
8. add test demonstrating addrLocal UB

   Github-Pull: #14728
   Rebased-From: 8ebbef016928811756e46b9086067d1c826797a8

   b90157891a
9. rpc: Make HTTP RPC debug logging more informative

   Github-Pull: #14618
   Rebased-From: 991248649b76a5a071e1360a700f3e2ecf3e1e1f

   9666dbaf09
10. Add SAFE_CHARS[SAFE_CHARS_URI]: Chars allowed in URIs (RFC 3986)

    Github-Pull: #14618
    Rebased-From: ab8c6f24d28ea1d1e6258cf316b4b97a0baf2377

    79358817e5
11. fanquake renamed this:
    [0.17] Backport #14593, #14596 and #14690
    [0.17] Further Backports
    on Nov 29, 2018
12. 
    MarcoFalke commented at 7:36 PM on November 29, 2018: member

    utACK 79358817e53ac0a7afa64c747115d492a74e3155

13. 
    gmaxwell commented at 2:50 AM on November 30, 2018: contributor

    utACK

14. qa: Avoid race in p2p_invalid_block by waiting for the block request

    Github-Pull: #14700
    Rebased-From: fa2156820877caf70fc09c7e6244b7cde6ebaf29

    f9db08e8ca
15. 
    fanquake commented at 2:44 PM on November 30, 2018: member

    I've added fa2156820877caf70fc09c7e6244b7cde6ebaf29 from #14700. The first commit (6c787d340cdb67bbdc508b562283750c7ed5dfa8) which removes a : to make the tests pass on CentOS doesn't seem to need a backport.

16. MarcoFalke merged this on Nov 30, 2018
17. MarcoFalke closed this on Nov 30, 2018

    ---

18. MarcoFalke referenced this in commit d8bc0ce1da on Nov 30, 2018
19. fanquake deleted the branch on Nov 30, 2018
20. MarcoFalke locked this on Sep 8, 2021

Milestone
0.17.1