[do not merge] [tests] tidy up wallet_importmulti.py #14952

   0 | @@ -0,0 +1,5 @@
   1 | +Low-level RPC changes
   2 | +---------------------
   3 | +
   4 | +The `importmulti` RPC will now contain a new per-request `warnings` field with strings
   5 | +that explain when fields are being ignored or inconsistant, if any.

practicalswift commented at 10:15 AM on December 14, 2018:

Should be "inconsistent" :-)

  87 | +    def test_importmulti(self, req, success, error_code=None, error_message=None, warnings=[]):
  88 |          """Run importmulti and assert success"""
  89 |          result = self.nodes[1].importmulti([req])
  90 | +        observed_warnings = []
  91 | +        if 'warnings' in result[0]:
  92 | +           observed_warnings = result[0]['warnings']

practicalswift commented at 10:15 AM on December 14, 2018:

Indentation is not a multiple of four :-)

  82 | -                        script_to_p2wsh(script_code),  # p2wsh addr
  83 | -                        CScript([OP_HASH160, witness_script, OP_EQUAL]).hex(),  # p2sh-p2wsh
  84 | -                        script_to_p2sh_p2wsh(script_code))  # p2sh-p2wsh addr
  85 | -
  86 | -    def test_importmulti(self, req, success, error_code=None, error_message=None):
  87 | +    def test_importmulti(self, req, success, error_code=None, error_message=None, warnings=[]):

practicalswift commented at 10:21 AM on December 14, 2018:

I suggest using warnings=None instead to clarify that warnings is not meant to be remembered across calls.

Background:

>>> def test(i, i_arr=[]):
...     i_arr.append(i)
...     return i_arr
...
>>> test(1)
[1]
>>> test(2)
[1, 2]
>>> test(3)
[1, 2, 3]

Suggested alternative:

>>> def test(i, i_arr=None):
...     if i_arr is None:
...         i_arr=[]
...     i_arr.append(i)
...     return i_arr
...
>>> test(1)
[1]
>>> test(2)
[2]
>>> test(3)
[3]