[qt] Ensure tx send error highlight is visible #14956

pull bpay wants to merge 2 commits into bitcoin:master from bpay:show-highlighted-field changing 1 files +2 −1

bpay commented at 5:12 AM on December 14, 2018: contributor

If sending to multiple recipients and one of the recipient fields is malformed, the highlighted field may have been scrolled out of view leading to a confusing lack of error feedback when clicking Send. To avoid this problem ensure the first field containing an error is scrolled into view when Send is clicked.

[qt] Ensure tx send error highlight is visible

If sending to multiple recipients and one of the recipient fields is malformed,
the highlighted field may not be visible due to being scrolled out of view
leading to a confusing lack of error feedback when clicking Send.  To avoid
this problem ensure the first field containing an error is scrolled into view
when Send is clicked.

9ae0b8c108

fanquake added the label GUI on Dec 14, 2018
benthecarman commented at 3:51 PM on December 16, 2018: contributor

Looks good, thanks for the improvement. utACK

promag commented at 3:24 PM on December 17, 2018: member

utACK 9ae0b8c.

However I think current code could be improved by dropping valid var, like:

for (...) {
    SendCoinsEntry *entry = ...;
    if (!entry) continue;
    if (!entry->validate(model->node())) {
        ui->scrollArea->ensureWidgetVisible(entry);
        return;
    }
}

if (recipients.isEmpty()) return;

promag commented at 12:59 AM on December 31, 2018: member

@bpay are you going to leave as it is?
bpay commented at 6:58 AM on January 2, 2019: contributor

@promag I believe your proposed change would result in only the first malformed entry being marked invalid in the case of multiple bad entries, since validate() is doing the highlighting. Seems more desirable to maintain the current behavior of validating the whole list at once
Fix formatting 4726e75508

in src/qt/sendcoinsdialog.cpp:233 in 9ae0b8c108 outdated

 229 | @@ -230,8 +230,9 @@ void SendCoinsDialog::on_sendButton_clicked()
 230 |              {
 231 |                  recipients.append(entry->getValue());
 232 |              }
 233 | -            else
 234 | +            else if(valid)

practicalswift commented at 4:38 PM on January 5, 2019:

Nit: Space before ( :-)

fanquake commented at 11:42 AM on August 23, 2019: member

I've rebased and squashed this in #16694.
fanquake closed this on Aug 23, 2019
fanquake referenced this in commit d86a906a88 on Aug 24, 2019
PastaPastaPasta referenced this in commit 33fd172c53 on Jun 27, 2021
PastaPastaPasta referenced this in commit 81204fcb78 on Jun 28, 2021
PastaPastaPasta referenced this in commit d8f5b1e167 on Jun 29, 2021
PastaPastaPasta referenced this in commit ed0722bfd5 on Jul 1, 2021
PastaPastaPasta referenced this in commit 448d64dd6b on Jul 1, 2021
PastaPastaPasta referenced this in commit 66efe7bcb0 on Jul 12, 2021
PastaPastaPasta referenced this in commit ae01429338 on Jul 13, 2021
MarcoFalke locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#16694 gui: Ensure transaction send error is always visible