tests: Fix cuckoocache_tests TSAN failure introduced in 14935. #14969

1. 
   practicalswift commented at 9:51 am on December 15, 2018: contributor

   Fix cuckoocache_tests TSAN failure introduced in #14935. Fixes #14967.
2. in src/test/cuckoocache_tests.cpp:224 in c07910b184 outdated

   220@@ -221,7 +221,7 @@ static void test_cache_erase_parallel(size_t megabytes)
   221             size_t start = ntodo*x;
   222             size_t end = ntodo*(x+1);
   223             for (uint32_t i = start; i < end; ++i)
   224-                BOOST_CHECK(set.contains(hashes[i], true));
   225+                set.contains(hashes[i], true);
   

   ---

   ---

   

   sipa commented at 9:53 am on December 15, 2018:

   This is a statement with no effect
3. fanquake added the label Tests on Dec 15, 2018
4. 
   ken2812221 commented at 12:52 pm on December 15, 2018: contributor

   Could use assert instead
5. fanquake renamed this:
   Fix cuckoocache_tests TSAN failure introduced in #14935. Fixes #14967.
   tests: Fix cuckoocache_tests TSAN failure introduced in 14935.
   on Dec 15, 2018
6. Fix cuckoocache_tests TSAN failure introduced in #14935. Fixes #14967. d98a29ec40
7. 
   practicalswift commented at 3:20 pm on December 15, 2018: contributor

   @sipa @ken2812221 Updated. Please re-review :-)
8. 
   laanwj commented at 6:48 pm on December 15, 2018: member

   utACK (but squash please)
9. practicalswift force-pushed on Dec 15, 2018
10. 
    practicalswift commented at 7:40 pm on December 15, 2018: contributor

    @laanwj Squashed! :-)
11. 
    Empact commented at 7:50 pm on December 15, 2018: member

    utACK d98a29e
12. 
    ken2812221 commented at 6:40 am on December 16, 2018: contributor

    utACK d98a29ec408590e54f405a7f8d232cd9dc5b14da
13. laanwj merged this on Dec 16, 2018
14. laanwj closed this on Dec 16, 2018

    ---

15. laanwj referenced this in commit 3424171685 on Dec 16, 2018
16. deadalnix referenced this in commit a06ba8d57a on Jun 22, 2020
17. practicalswift deleted the branch on Apr 10, 2021
18. dzutto referenced this in commit f339f3de57 on Sep 24, 2021
19. dzutto referenced this in commit 9d408b364a on Sep 24, 2021
20. dzutto referenced this in commit eb0a3d833d on Sep 24, 2021
21. dzutto referenced this in commit 298a64983f on Sep 27, 2021
22. dzutto referenced this in commit 6e91a22d80 on Sep 30, 2021
23. UdjinM6 referenced this in commit 4c72a1a975 on Oct 1, 2021
24. kittywhiskers referenced this in commit 1983b3602d on Oct 12, 2021
25. DrahtBot locked this on Aug 18, 2022

Contributors
practicalswift sipa ken2812221 laanwj Empact

Labels
Tests