qt: Fix broken notificator on GNOME #15000

1. 
   hebasto commented at 12:28 AM on December 19, 2018: member

   Fix #14994; that bug was introduced in #14228 (that was my fault).

   ~Also this commit explicit separates~ There are two functions of the tray icon:

   • a system tray widget (QSystemTrayIcon::isSystemTrayAvailable() == true)
   • a high-level notificator via balloon messages (QSystemTrayIcon::supportsMessages() == true)

   ~These properties are mutually independent,~ e.g., on Fedora 29 + GNOME:

   QSystemTrayIcon::isSystemTrayAvailable() == false;
   QSystemTrayIcon::supportsMessages() == true;
   

   UPDATE:

   supportsMessages() makes no sense without isSystemTrayAvailable(): QSystemTrayIcon::showMessage() just not working on Fedora 29 + GNOME.

2. fanquake added the label GUI on Dec 19, 2018
3. 
   DrahtBot commented at 3:33 AM on December 19, 2018: member

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #11625 (Add BitcoinApplication & RPCConsole tests by ryanofsky)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. 
   laanwj commented at 10:03 AM on December 19, 2018: member

   Concept ACK, TIL that those are separate

5. MarcoFalke added this to the milestone 0.18.0 on Dec 19, 2018
6. hebasto renamed this:
   qt: Fix broken notificator on GNOME
   [WIP] qt: Fix broken notificator on GNOME
   on Dec 19, 2018
7. Fix broken notificator on GNOME

   That bug was introduced in #14228.

   c8d9d9093b
8. hebasto force-pushed on Dec 19, 2018
9. 
   hebasto commented at 7:03 PM on December 19, 2018: member

   @laanwj Thank you for your review.

   Concept ACK, TIL that those are separate

   TIL too: supportsMessages() makes no sense without isSystemTrayAvailable(). Sorry for confusing.

   PR description and commit have been updated.

10. hebasto renamed this:
    [WIP] qt: Fix broken notificator on GNOME
    qt: Fix broken notificator on GNOME
    on Dec 19, 2018
11. 
    fanquake commented at 3:07 PM on January 2, 2019: member

    Tested c8d9d90 on Fedora 29.1-2. No longer causes a segfault when a notification appears. Created notifications using:

    getnewaddress
    generatetoaddress 1 the_new_address
    

    

    However, from a quick check, this seems to break notifications on macOS (10.14.2). i.e if I make deploy this PR, and run with -regtest, I no longer see incoming transaction notifications in the Notification Centre when using generatetoaddress. Be good if someone else could confirm.

12. 
    promag commented at 3:44 PM on January 2, 2019: member

    @fanquake I can't reproduce your case. All notifications go to notification centre but they don't popup when calling from the console window.

13. MarcoFalke merged this on Jan 2, 2019
14. MarcoFalke closed this on Jan 2, 2019

    ---

15. MarcoFalke referenced this in commit fb52d0684e on Jan 2, 2019
16. 
    hebasto commented at 4:33 PM on January 2, 2019: member

    @fanquake

    ... this seems to break notifications on macOS (10.14.2). @promag

    All notifications go to notification centre but they don't popup when calling from the console window.

    See: #14976 (comment)

17. hebasto deleted the branch on Jan 2, 2019
18. Munkybooty referenced this in commit 1eb7a514f7 on Aug 10, 2021
19. Munkybooty referenced this in commit a73eb08dca on Aug 11, 2021
20. Munkybooty referenced this in commit f6b1552e85 on Aug 11, 2021
21. Munkybooty referenced this in commit bf57e76984 on Aug 13, 2021
22. Munkybooty referenced this in commit 211c3cace6 on Aug 15, 2021
23. MarcoFalke locked this on Dec 16, 2021

Contributors

hebastoDrahtBotlaanwjfanquakepromag

Milestone
0.18.0