On Fedora 29.1-2, when running bitcoin-qt -regtest, the name of the application in the menu bar is shown as Bitcoin-Qt-testnet (the icon is the correct blue colour). i.e:
Noticed while testing #15000 (confirmed unrelated by testing master). When running just bitcoin-qt, or passing -testnet the menu name and icon are both correct.
The same application name
#define QAPP_APP_NAME_TESTNET "Bitcoin-Qt-testnet"
is used for both regtest and testnet:
{"test", QAPP_APP_NAME_TESTNET, 70, 30, QT_TRANSLATE_NOOP("SplashScreen", "[testnet]")},
{"regtest", QAPP_APP_NAME_TESTNET, 160, 30, "[regtest]"}
No, to be honest I don't think anyone ever noticed this, or thought of this before. Regtest in GUI mode is very rarely used.
The application name itself is not a huge deal... but without the fix #15085, regtest and testnet GUI share the same QSettings which is strange that nobody detected this (including myself using GUI regtest a lot).
regtest and testnet GUI share the same QSettings
Oh nice when this annoyance is finally fixed. Makes testing easier and less risky.