qt: Notificator class refactoring #15007

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:20181219-notificator-enhancement changing 2 files +12 −14

hebasto commented at 11:20 PM on December 19, 2018: member
This PR:
- removes misplaced Q_UNUSED(cls); cls is actually used: https://github.com/bitcoin/bitcoin/blob/eb7daf4d600eeb631427c018a984a77a34aca66e/src/qt/notificator.cpp#L188
- removes unused parameters in functions notifySystray() and notifyMacUserNotificationCenter()
- improves comments

Remove misplaced Q_UNUSED and others enhancements

Also this removes unused function parameters and improves comments.

698d0f882a

fanquake added the label GUI on Dec 19, 2018
practicalswift commented at 7:05 AM on December 21, 2018: contributor

Concept ACK

Nice cleanup!
DrahtBot commented at 12:48 PM on December 21, 2018: member



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

No conflicts as of last run.
promag commented at 12:58 AM on December 31, 2018: member

Concept ACK, will test.
promag commented at 1:03 PM on January 2, 2019: member

tACK 698d0f8 on macOS 10.14.1. Updated comments also LGTM.
fanquake commented at 1:54 PM on January 2, 2019: member

Quickly-tested ACK 698d0f8 Checked that notifications work on macOS:
laanwj commented at 9:30 AM on January 4, 2019: member

utACK 698d0f882a852b8d36abdf11e7729422979bb1fd
laanwj merged this on Jan 4, 2019
laanwj closed this on Jan 4, 2019
laanwj referenced this in commit f51aeac5ad on Jan 4, 2019
hebasto deleted the branch on Jan 4, 2019
PastaPastaPasta referenced this in commit 10667a88b7 on Jun 26, 2021
PastaPastaPasta referenced this in commit f5f3695f4b on Jun 28, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels