qt: Notificator class refactoring #15007

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:20181219-notificator-enhancement changing 2 files +12 −14
  1. hebasto commented at 11:20 PM on December 19, 2018: member

    This PR:

  2. Remove misplaced Q_UNUSED and others enhancements
    Also this removes unused function parameters and improves comments.
    698d0f882a
  3. fanquake added the label GUI on Dec 19, 2018
  4. practicalswift commented at 7:05 AM on December 21, 2018: contributor

    Concept ACK

    Nice cleanup!

  5. DrahtBot commented at 12:48 PM on December 21, 2018: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    No conflicts as of last run.

  6. promag commented at 12:58 AM on December 31, 2018: member

    Concept ACK, will test.

  7. promag commented at 1:03 PM on January 2, 2019: member

    tACK 698d0f8 on macOS 10.14.1. Updated comments also LGTM.

  8. fanquake commented at 1:54 PM on January 2, 2019: member

    Quickly-tested ACK 698d0f8 Checked that notifications work on macOS: notifications - 15007

  9. laanwj commented at 9:30 AM on January 4, 2019: member

    utACK 698d0f882a852b8d36abdf11e7729422979bb1fd

  10. laanwj merged this on Jan 4, 2019
  11. laanwj closed this on Jan 4, 2019

  12. laanwj referenced this in commit f51aeac5ad on Jan 4, 2019
  13. hebasto deleted the branch on Jan 4, 2019
  14. PastaPastaPasta referenced this in commit 10667a88b7 on Jun 26, 2021
  15. PastaPastaPasta referenced this in commit f5f3695f4b on Jun 28, 2021
  16. DrahtBot locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me