Update base Travis OS to xenial from trusty.
Link to Travis Docs for Xenial: https://docs.travis-ci.com/user/reference/xenial/
As noted in the documentation, Docker version is also updated from 17.06 to 18.06
Also includes: - If running Bitcoin config with LSan sanitizer, Allow ptrace in Docker run command - Increase timeout of feature_assumevalid test to fix flaky tests
This also updates the compilers and build toolchain, but that shouldn't matter on the host because everything is ran inside of Docker, correct?
clang and llvm 7
cmake 3.12.4
gcc 5.4.0
ccache 3.2.4
https://docs.travis-ci.com/user/reference/xenial/#compilers-and-build-toolchain
I can't find a legitimate reason by looking through the Docker changelogs or documentation, but when running tests with LSan sanitizer, Docker requires the --cap-add SYS_PTRACE flag set in v18.06. This didn't seem to be a problem with v17.06
See relevant issue here: https://github.com/google/sanitizers/issues/764
@gkrizek please stop opening and closing this :)
Sorry, @MeshCollider. The first time was an accident then the second was to trigger a new CI run. One of the tests seems flaky, but I’ll test that in my fork. :)
@gkrizek To trigger a new build, you can set up an account at travis-ci.org and control the builds under: http://travis-ci.org/gkrizek/bitcoin
This is complete and ready for review. I've fixed some issues with tests and builds are passing consistently.
14 | @@ -15,6 +15,8 @@ export UBSAN_OPTIONS="suppressions=${TRAVIS_BUILD_DIR}/test/sanitizer_suppressio 15 | env | grep -E '^(BITCOIN_CONFIG|CCACHE_|WINEDEBUG|LC_ALL|BOOST_TEST_RANDOM|CONFIG_SHELL|(ASAN|LSAN|TSAN|UBSAN)_OPTIONS)' | tee /tmp/env 16 | if [[ $HOST = *-mingw32 ]]; then 17 | DOCKER_ADMIN="--cap-add SYS_ADMIN" 18 | +elif [[ $BITCOIN_CONFIG = *--with-sanitizers=*address* ]]; then # If ran with (ASan + LSan), Docker needs access to ptrace
nit: Maybe worth linking to one of these? https://github.com/google/sanitizers/issues/916 https://github.com/google/sanitizers/issues/764
Thanks for the suggestion. I added a link in the comment
This should probably be broken into two or three commits. i.e the Travis change (with/without the sanitizer change) and then the test timeout change in a separate commit.
Updating the base OS used in Travis to Xenial from Trusty. This also updates Docker to 18.06 instead of 17.06 in CI.
See https://github.com/google/sanitizers/issues/764 for details
utACK b6f0db69a9c9cdf101371720351935121590d3aa. We don't use any features from the travis image other than docker, so changing it shouldn't matter.
Thanks @MarcoFalke. If anything we might get slightly faster build times.
utACK b6f0db6 - appveyor is the failure.
It looks like this ran about 5 minutes faster than another PR I have open. So I haven’t done testing to compare speeds, but it does seem faster.
Oh nice. Thanks for the speedup