Mwortham #15036

pull markaw67 wants to merge 1 commits into bitcoin:master from markaw67:patch-2 changing 1 files +76 −0
  1. markaw67 commented at 5:22 AM on December 26, 2018: none

    Code of conduct

    Pull requests without a rationale and clear improvement may be closed immediately.

    Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly.

    • Any test improvements or new tests that improve coverage are always welcome.
    • All other changes should have accompanying unit tests (see src/test/) or functional tests (see test/). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change.
    • Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed.
    • Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible.
    • Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they significantly improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the developer notes, stylistic code changes are usually rejected.

    Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time.

  2. Mwortham
    Code of conduct
    f30e62248a
  3. fanquake added the label Docs on Dec 26, 2018
  4. fanquake commented at 5:44 AM on December 26, 2018: member

    Thanks for contributing. However:

    Please use a prefixed and meaningful commit message.

    Please read and actually fill out the PR description, removing the template text:

    Pull requests without a rationale and clear improvement may be closed immediately.

    Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly.

    For reference #7243 and #11543 are the last two times somebody tried to add a code of conduct to this project, and I agree with @MarcoFalke's comment:

    Agree that this one is out of scope for the Bitcoin Core GitHub project. Furthermore I don't think we should collect and add documents to our git tree that describe common sense. To the best of my knowledge, none of the inappropriate behavior mentioned in the document ever happened within the Bitcoin Core GitHub project. Feel free to prove me wrong, but I propose to close this.

  5. markaw67 commented at 5:49 AM on December 26, 2018: none

    So your saying you disagree you think that its not important.

  6. vinhmako99777 approved
  7. fanquake commented at 6:34 AM on December 26, 2018: member

    Contributions to this project are always welcome, however, PRs (regardless of the content), which have been opened without following any of the contributor guidelines, disregard PR templates and ignore feedback from maintainers are are going to be closed.

    If you'd like to get started contributing, I'd suggest checking out the good first issue list, or helping review one of the hundreds of open PRs, as the project is regularly bottlenecked by active reviewers.

  8. fanquake closed this on Dec 26, 2018

  9. fanquake locked this on Dec 26, 2018

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 18:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me