Two cleanups in util/strencodings.h:
[U](BEGIN|END) macros — The only use of these was in the Merkle tree code with uint256 which has its own begin and end methods which are better.std::string elements are (bare) chars. As these are the most likely type to be passed to these functions, make them use char instead of unsigned char. This avoids some casts.
Replace use of `BEGIN` and `END` macros on uint256 with `begin()` and
`end()` methods in the Merkle tree code.
Unfortunately, `std::string` elements are (bare) chars. As these
are the most likely type to be passed to these functions, make them use
char instead of unsigned char. This avoids some casts.
utACK 332b3dd - could squash the first two
utACK 332b3dd7c156daa08df347dc3359f0ee99ce4baa
utACK 332b3dd.
utACK 332b3dd7c156daa08df347dc3359f0ee99ce4baa
Would be nice to have #15134 merged for extra checking of these types of changes :-)
utACK
588 | @@ -589,7 +589,7 @@ bool ParseHDKeypath(const std::string& keypath_str, std::vector<uint32_t>& keypa 589 | 590 | void Downcase(std::string& str) 591 | { 592 | - std::transform(str.begin(), str.end(), str.begin(), [](unsigned char c){return ToLower(c);}); 593 | + std::transform(str.begin(), str.end(), str.begin(), [](char c){return ToLower(c);});
Just realizing that it's passing a silly identity function:
std::transform(str.begin(), str.end(), str.begin(), ToLower);
Anyhow, not going to file a PR for just that, I guess the compiler optimizes this away, maybe someone touching this code in the future can take it into account.