[Consensus] [P2P] [Utils and libraries] Cleanup #15151

1. 
   DesWurstes commented at 7:11 am on January 12, 2019: contributor

   1st commit: Cleanup, because prevHeights is never nullptr. 2nd commit: #14130 3rd commit: strncpy(pchCommand, pszCommand, COMMAND_SIZE); implies first doing memset(pchCommand, 0, COMMAND_SIZE);
2. Pass prevheights by reference e5629210e2
3. Avoid unnamed struct, which is a GNU extension d58d7422a6
4. Unneeded memset in CMessageHeader d4e9c2814b
5. fanquake added the label Consensus on Jan 12, 2019
6. 
   DrahtBot commented at 8:37 am on January 12, 2019: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #15141 (Rewrite DoS interface between validation and net_processing by sdaftuar)
   • #14266 (Lift prevector default vals to the member declaration by Empact)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. 
   practicalswift commented at 9:43 am on January 12, 2019: contributor

   @DesWurstes Since these are unrelated changes would you mind submitting them as three separate PR:s?
8. 
   Mr-Leshiy commented at 1:32 pm on January 12, 2019: contributor

   I am not sure about the first commit called “Pass prevheights by reference”. Because according to the Straustrup book usually using a poiter of a parameter in a method is good when you are going to change the value of the parameter and const reference when you are not going to change the value.
9. 
   gmaxwell commented at 8:51 am on January 13, 2019: contributor

   Please articulate the benefits of the proposed changes. “Cleanup” isn’t an acceptable explanation except for the most trivial of changes (and trivial cleanup is usually not welcome accept as part of other work).
10. DesWurstes closed this on Jan 25, 2019

    ---

11. DrahtBot locked this on Dec 16, 2021

Contributors
DesWurstes DrahtBot practicalswift Mr-Leshiy gmaxwell

Labels
Consensus