rpc: remove duplicate solvable field from getaddressinfo #15186

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:duplicate-solvable-fields changing 1 files +1 −3

fanquake commented at 7:30 AM on January 17, 2019: member

Also added optional to iscompressed.
fanquake added the label Docs on Jan 17, 2019
fanquake added the label RPC/REST/ZMQ on Jan 17, 2019
promag commented at 7:34 AM on January 17, 2019: member

ACK, nice catch.
fanquake force-pushed on Jan 17, 2019
fanquake commented at 7:58 AM on January 17, 2019: member

Travis failure seems unrelated. Force pushed, added optional to iscompressed.
laanwj commented at 10:46 AM on January 17, 2019: member

Huh, how did we have it end up like this, a silent merge conflict?

(utACK, good catch)
Empact commented at 11:25 AM on January 17, 2019: member

utACK https://github.com/bitcoin/bitcoin/pull/15186/commits/a5db68c22ba03e661d20b1855e6a443019080690
hebasto commented at 11:43 AM on January 17, 2019: member

utACK a5db68c22ba03e661d20b1855e6a443019080690
promag commented at 1:00 PM on January 17, 2019: member

Should backport?
fanquake commented at 1:37 PM on January 17, 2019: member

@promag getaddressinfo in 0.17 doesn't have any solvable fields, so shouldn't be required. https://github.com/bitcoin/bitcoin/blob/0a0b2ea11fde7becbdd1c04205336c3a39bffbc0/src/wallet/rpcwallet.cpp#L4149

in src/wallet/rpcwallet.cpp:3607 in a5db68c22b outdated

3603 | @@ -3605,7 +3604,7 @@ UniValue getaddressinfo(const JSONRPCRequest& request)
3604 |              "  \"sigsrequired\" : xxxxx        (numeric, optional) Number of signatures required to spend multisig output (only if \"script\" is \"multisig\")\n"
3605 |              "  \"pubkey\" : \"publickeyhex\",    (string, optional) The hex value of the raw public key, for single-key addresses (possibly embedded in P2SH or P2WSH)\n"
3606 |              "  \"embedded\" : {...},           (object, optional) Information about the address embedded in P2SH or P2WSH, if relevant and known. It includes all getaddressinfo output fields for the embedded address, excluding metadata (\"timestamp\", \"hdkeypath\", \"hdseedid\") and relation to the wallet (\"ismine\", \"iswatchonly\").\n"
3607 | -            "  \"iscompressed\" : true|false,  (boolean) If the address is compressed\n"
3608 | +            "  \"iscompressed\" : true|false,  (boolean, optional) If the address is compressed\n"

MarcoFalke commented at 2:59 PM on January 17, 2019:

Shouldn't this say pubkey?

            "  \"iscompressed\" : true|false,  (boolean, optional) If the pubkey is compressed\n"

MarcoFalke commented at 3:00 PM on January 17, 2019: member

ACK
achow101 commented at 6:41 PM on January 17, 2019: member

utACK a5db68c22ba03e661d20b1855e6a443019080690
rpc: remove duplicate solvable field from getaddressinfo a2a6c8f453
fanquake force-pushed on Jan 18, 2019
IlyasRidhuan commented at 3:16 PM on January 18, 2019: none

utAck
laanwj merged this on Jan 19, 2019
laanwj closed this on Jan 19, 2019
laanwj referenced this in commit fe60ee96e9 on Jan 19, 2019
fanquake deleted the branch on Jan 19, 2019
UdjinM6 referenced this in commit 9f6c237737 on Nov 24, 2021
UdjinM6 referenced this in commit f088d2eb9c on Nov 29, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels