fees: Complete the removal of fee-estimation file read code for old versions #15187

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:fee-estimation changing 1 files +5 −5
  1. practicalswift commented at 3:27 PM on January 17, 2019: contributor

    Complete the removal of fee-estimation file read code for old versions.

    This completes the removal started by @TheBlueMatt in #11951:

    0.15.0 introduced a new feeest file format, and support for parsing old versions was never fully added. We now simply fail to read the old format, so remove the dead partial-implementation.

  2. fees: Complete the removal of fee-estimation file read code for old versions
    Complete the removal of fee-estimation file read code for old versions.
    
    This completes the removal performed in 62e7c04fb82c1b99ee27b61af17cda343c9f9912.
    d5af70439f
  3. fanquake added the label Refactoring on Jan 17, 2019
  4. DrahtBot commented at 4:26 PM on January 17, 2019: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #13990 (Allow fee estimation to work with lower fees by ajtowns)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  5. laanwj commented at 5:18 PM on January 17, 2019: member

    I'm not convinced this change is necessary. It doesn't really remove any code, just the version argument, which might be useful in case a new format is introduced in the future.

  6. practicalswift closed this on Jan 17, 2019

  7. practicalswift commented at 7:16 PM on January 17, 2019: contributor

    @laanwj OK, closing!

  8. laanwj commented at 2:38 PM on January 20, 2019: member

    That up to you. To be clear: my opinion here is not a strong NACK, and it's possible others think differently about it.

  9. practicalswift commented at 2:56 PM on January 20, 2019: contributor

    @laanwj I'll let others chime in and re-open if requested :-)

  10. practicalswift deleted the branch on Apr 10, 2021
  11. DrahtBot locked this on Aug 18, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-16 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me