lint: Bump flake8 to 3.6.0 #15221

pull Empact wants to merge 1 commits into bitcoin:master from Empact:flake-36 changing 21 files +50 −67

Empact commented at 2:02 AM on January 21, 2019: member

Fix new lints in: W504 line break after binary operator W605 invalid escape sequence F841 local variable 'e' is assigned to but never used

https://github.com/PyCQA/flake8/blob/master/docs/source/release-notes/3.6.0.rst

lint: Bump flake8 to 3.6.0

Fix new lints in:
W504 line break after binary operator
W605 invalid escape sequence
F841 local variable 'e' is assigned to but never used

https://github.com/PyCQA/flake8/blob/master/docs/source/release-notes/3.6.0.rst

ddd5d31d66

fanquake added the label Scripts and tools on Jan 21, 2019
practicalswift commented at 2:23 PM on January 21, 2019: contributor

utACK ddd5d31d66f3a6ca8737f1249a8ddd830bff8950

Thanks for doing this!
promag commented at 4:30 PM on January 21, 2019: member

LGTM.

in contrib/devtools/copyright_header.py:89 in ddd5d31d66

  85 | @@ -87,20 +86,20 @@ def compile_copyright_regex(copyright_style, year_style, name):
  86 |      "Bitcoin Core Developers\n",
  87 |      "the Bitcoin Core developers\n",
  88 |      "The Bitcoin developers\n",
  89 | -    "The LevelDB Authors\. All rights reserved\.\n",
  90 | -    "BitPay Inc\.\n",
  91 | -    "BitPay, Inc\.\n",
  92 | -    "University of Illinois at Urbana-Champaign\.\n",
  93 | +    r"The LevelDB Authors\. All rights reserved\.\n",

laanwj commented at 7:47 PM on January 21, 2019:

I don't think simply adding r here is correct.

>>> "The LevelDB Authors\. All rights reserved\.\n" == r"The LevelDB Authors\. All rights reserved\.\n"
False

A raw string will contain literal .\n`` which is not the intent here.

laanwj commented at 7:55 PM on January 21, 2019:

the problem here is that the . should not be escaped, not that the string is not raw !

Empact commented at 12:45 AM on January 22, 2019: member

Planning to re-open later.
Empact closed this on Jan 22, 2019
MarcoFalke referenced this in commit 45be44cce4 on Sep 5, 2019
UdjinM6 referenced this in commit dc815a5c84 on Sep 10, 2021
UdjinM6 referenced this in commit cca3dd9468 on Sep 24, 2021
UdjinM6 referenced this in commit e6a3fbd23a on Oct 4, 2021
UdjinM6 referenced this in commit 60b3c5a64e on Oct 5, 2021
kittywhiskers referenced this in commit e41e5996d6 on Oct 12, 2021
pravblockc referenced this in commit 71f0b12bf2 on Nov 18, 2021
MarcoFalke locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#15257 Scripts and tools: Bump flake8 to 3.7.8