wallet: Clarify rescanblockchain doc #15279

1. 
   MarcoFalke commented at 10:31 PM on January 28, 2019: member

   This was probably accidentally added to the wrong line when addressing the feedback here: #7061 (review)

   I already added the default values in #14877, but it could be clarified more that this really has no specific block height as default value, since the tip can change during a rescan.

2. MarcoFalke renamed this:
   wallet: Fixup rescanblockchain result doc
   wallet: Clarify rescanblockchain doc
   on Jan 28, 2019
3. MarcoFalke added the label RPC/REST/ZMQ on Jan 28, 2019
4. MarcoFalke added the label Docs on Jan 28, 2019
5. MarcoFalke added the label Wallet on Jan 28, 2019
6. MarcoFalke force-pushed on Jan 28, 2019
7. 
   DrahtBot commented at 11:58 PM on January 28, 2019: member

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #14918 (RPCHelpMan: Check default values are given at compile-time by MarcoFalke)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

8. in src/wallet/rpcwallet.cpp:3372 in fa1484bbd1 outdated

   3368 | @@ -3369,13 +3369,13 @@ UniValue rescanblockchain(const JSONRPCRequest& request)
   3369 |                  "\nRescan the local blockchain for wallet related transactions.\n",
   3370 |                  {
   3371 |                      {"start_height", RPCArg::Type::NUM, /* opt */ true, /* default_val */ "0", "block height where the rescan should start"},
   3372 | -                    {"stop_height", RPCArg::Type::NUM, /* opt */ true, /* default_val */ "tip height", "the last block height that should be scanned"},
   3373 | +                    {"stop_height", RPCArg::Type::NUM, /* opt */ true, /* default_val */ "", "the last block height that should be scanned. If none is provided it will rescan up to the tip."},
   

   ---

   ---

   

   promag commented at 2:46 PM on January 29, 2019:

   nit, to the tip at call time, not return time.

   ---

   

   MarcoFalke commented at 2:54 PM on January 29, 2019:

   No, at return time, actually

   ---

   

   promag commented at 2:59 PM on January 29, 2019:

   Err sorry, I messed it 🤦‍♂️I meant that.

   ---

   

   MarcoFalke commented at 5:53 PM on January 29, 2019:

   Thanks, took your suggestion.

9. 
   promag commented at 2:49 PM on January 29, 2019: member

   ACK fa1484b, response keys are always present. Default stop_height value is dynamic so makes sense to describe it. Could just add a small note (sorry the bad wording).

10. fanquake added the label Needs rebase on Jan 29, 2019
11. wallet: Fixup rescanblockchain result doc fa5e6ef55c
12. MarcoFalke force-pushed on Jan 29, 2019
13. 
    promag commented at 5:58 PM on January 29, 2019: member

    ACK fa5e6ef.

14. DrahtBot removed the label Needs rebase on Jan 29, 2019
15. ryanofsky approved
16. 
    ryanofsky commented at 8:56 PM on January 29, 2019: member

    utACK fa5e6ef55c4741e34bc977020194302e59b12aee

17. 
    promag commented at 9:38 PM on January 29, 2019: member

    Unrelated travis failure.

    For reference, the fail was: <img width="1209" alt="screenshot 2019-01-29 at 21 37 10" src="https://user-images.githubusercontent.com/3534524/51942083-1a3f2a00-240e-11e9-9f9f-1d5c8606fb1e.png">

18. 
    Empact commented at 6:23 PM on January 30, 2019: member

    utACK https://github.com/bitcoin/bitcoin/pull/15279/commits/fa5e6ef55c4741e34bc977020194302e59b12aee

19. MarcoFalke added this to the milestone 0.18.0 on Jan 30, 2019
20. MarcoFalke merged this on Jan 30, 2019
21. MarcoFalke closed this on Jan 30, 2019

    ---

22. MarcoFalke referenced this in commit 04226f8706 on Jan 30, 2019
23. MarcoFalke deleted the branch on Jan 30, 2019
24. deadalnix referenced this in commit 3361af538c on May 4, 2020
25. Munkybooty referenced this in commit ad34d67319 on Aug 21, 2021
26. Munkybooty referenced this in commit 8e2a2aac53 on Aug 23, 2021
27. Munkybooty referenced this in commit 5367671054 on Aug 24, 2021
28. Munkybooty referenced this in commit 68c722f867 on Aug 24, 2021
29. Munkybooty referenced this in commit fcd4c15ad6 on Aug 24, 2021
30. UdjinM6 referenced this in commit 6cc03c0e81 on Aug 24, 2021
31. Munkybooty referenced this in commit 9b233fbc4c on Aug 24, 2021
32. DrahtBot locked this on Dec 16, 2021

Contributors

MarcoFalkeDrahtBotpromagryanofskyEmpact

Milestone
0.18.0