Fixes #15286.
Fix assertion in CKey::SignCompact #15299
pull promag wants to merge 1 commits into bitcoin:master from promag:2019-01-ckey-signcompact changing 1 files +1 −1-
promag commented at 3:01 PM on January 31, 2019: member
-
Fix assertion in CKey::SignCompact 3617f11739
-
laanwj commented at 3:09 PM on January 31, 2019: member
utACK 3617f117394285c87c395a0ccc92941977f97019
-
practicalswift commented at 3:54 PM on January 31, 2019: contributor
utACK 3617f117394285c87c395a0ccc92941977f97019
This is why I love
[[nodiscard]]:-) -
Empact commented at 6:00 PM on January 31, 2019: member
- laanwj merged this on Jan 31, 2019
- laanwj closed this on Jan 31, 2019
- laanwj referenced this in commit 4b6673d382 on Jan 31, 2019
-
maaku commented at 6:20 PM on January 31, 2019: contributor
Already merged, but FWIW this is just as redundant.
secp256k1_ecdsa_recoverable_signature_serialize_compactalways returns 1; the serialization function semantics are that they never fail. No check is required. -
laanwj commented at 6:27 PM on January 31, 2019: member
secp256k1_ecdsa_recoverable_signature_serialize_compact always returns 1; the serialization function semantics are that they never fail. No check is required.
That's true—however, as long as it has a return value, I think it's correct to check it. It might start to do error handling in the future.
- jasonbcox referenced this in commit 0c7574e088 on Oct 1, 2020
- PastaPastaPasta referenced this in commit 15840af8b7 on Jun 27, 2021
- PastaPastaPasta referenced this in commit 924794db7a on Jun 28, 2021
- PastaPastaPasta referenced this in commit 5d1d202bc0 on Jun 28, 2021
- PastaPastaPasta referenced this in commit 8846f79220 on Jun 29, 2021
- DrahtBot locked this on Dec 16, 2021
