[Do Not Merge] break < Qt5.6 compatibility for addAction to test Travis #15320

1. 
   Sjors commented at 6:20 pm on February 1, 2019: member

   This reverts commit 3e21b690d1aedb73a7dc2bc5d2ff1b011b52d927 from #14979.

   #15308 should catch this

2. 
   MarcoFalke commented at 6:28 pm on February 1, 2019: member

   #15308 was only about boost. I have no opinion what our minimum supported version for qt should be.
3. 
   MarcoFalke commented at 6:36 pm on February 1, 2019: member

   Anyway, this should fail because xenial has qt5.5
4. 
   Empact commented at 7:30 pm on February 1, 2019: member

   Yeah I have a follow-up which should cover qt 5.4 - will have that up later today.
5. 
   Empact commented at 7:41 pm on February 1, 2019: member

   Incidentally, a good way to run these checks without a PR is to set up the repo on your personal travis account: https://travis-ci.org/sjors/bitcoin. e.g. https://travis-ci.org/Empact/bitcoin
6. 
   Sjors commented at 7:31 am on February 2, 2019: member

   The Trusty build passed though.

   I’m confused; #15308 switched Trusty (not Xenial) to NO_DEPENDS=1 which means it uses the package manager version QT, which should be 5.2:

   So the Trusty build should have failed, but didn’t.

   I realized I could have run it on my own repo about two seconds after making the PR :-)

7. jonasschnelli added the label GUI on Feb 2, 2019
8. 
   MarcoFalke commented at 7:53 pm on February 2, 2019: member

   See the --with-gui=no ;)

   https://github.com/bitcoin/bitcoin/blob/b3a715301a0fd972fb2f3bd36e2680b3cdbbab26/.travis.yml#L112

9. 
   Sjors commented at 10:06 pm on February 2, 2019: member

   @MarcoFalke aha, so we’re installing QT just for shits & giggles on that machine? :-)
10. 
    MarcoFalke commented at 10:19 pm on February 2, 2019: member

    For now, yes
11. 
    Empact commented at 4:35 pm on February 7, 2019: member

    #14998 has fixes for a few QT 5.2 issues, for example the current failure is fixed by 352f36e01c8b392ee785bfb356e71488858e5da8
12. 
    DrahtBot commented at 2:41 pm on February 8, 2019: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    No conflicts as of last run.

13. 
    Sjors commented at 7:08 pm on February 10, 2019: member

    @MarcoFalke when I enable GUI build on Trusty the compile fails as expected. Would that be safe to enable for Travis? No need to run the tests.
14. 
    Sjors commented at 7:17 pm on February 10, 2019: member

    Ah wait, it’s more confusing actually :-)

    When I enable GUI build, Travis blows up on a different error than the one I deliberately introduced. Namely the error @Empact fixes in 352f36e01c8b392ee785bfb356e71488858e5da8 (no PR).

    So in order to enable the GUI build like I did in 573d5af we’d have to add 352f36e01c8b392ee785bfb356e71488858e5da8 as well, otherwise all builds will fail.

15. 
    Sjors commented at 7:27 pm on February 10, 2019: member

    I cherry-picked 352f36e to see if Travis Trusty now fails with the error I expect.
16. 
    Sjors commented at 12:13 pm on February 11, 2019: member

    That didn’t seem to help much (log):

    Meanwhile Xenial uses QT 5.5 and does correctly break (log) on the addAction stuff.

17. Sjors force-pushed on Feb 21, 2019
18. Revert "[Qt] Restore < Qt5.6 compatibility for addAction"

    This reverts commit 3e21b690d1aedb73a7dc2bc5d2ff1b011b52d927.

    87bd16e583
19. Sjors force-pushed on Feb 21, 2019
20. 
    Sjors commented at 5:38 pm on February 21, 2019: member

    The minimum QT version was bumped to 5.5.1 in #15393, so I dropped the check for QT 5.4 and 5.2 from this PR. If all goes well only the QT 5.5.1 Xenial Travis job (8) should fail, and then I’ll close this.
21. 
    MarcoFalke commented at 6:00 pm on February 21, 2019: member

    @Sjors It failed
22. 
    Sjors commented at 8:10 am on February 22, 2019: member

    @MarcoFalke so did job 9 due to a timeout. Restarted, but I’m optimistic :-)
23. 
    Sjors commented at 9:05 am on February 22, 2019: member
24. Sjors closed this on Feb 22, 2019

    ---

25. Sjors deleted the branch on Feb 22, 2019
26. DrahtBot locked this on Dec 16, 2021

Contributors
Sjors MarcoFalke Empact DrahtBot

Labels
GUI