test: Make bloom tests deterministic #15324

1. 
   MarcoFalke commented at 10:17 pm on February 1, 2019: member

   non-deterministic tests are useless, since a failing test could not be reproduced unless the seed is known.
2. in src/random.h:242 in fa07e4f037 outdated

   235@@ -236,4 +236,8 @@ bool Random_SanityCheck();
   236  */
   237 void RandomInit();
   238 
   239+/**
   240+ * Flag to make GetRand return the same number
   241+ */
   242+extern bool g_mock_deterministic_tests;
   

   ---

   ---

   

   Empact commented at 10:36 pm on February 1, 2019:

   nit: Declare extern in test code so it’s not otherwise accessible in the non-test code?

   ---

   

   MarcoFalke commented at 7:14 pm on February 2, 2019:

   Done
3. 
   practicalswift commented at 10:45 pm on February 1, 2019: contributor

   Concept ACK

   Non-deterministic tests and the sources of non-determinism are documented in #15296.

4. jonasschnelli added the label Tests on Feb 2, 2019
5. 
   laanwj commented at 10:56 am on February 2, 2019: member

   non-deterministic tests are useless, since a failing test could not be reproduced unless the seed is known

   :+1: (also people are likely to re-run the tests before investigating deeply so won’t learn anything from a random failure)

6. test: Make bloom tests deterministic fae169c95e
7. MarcoFalke force-pushed on Feb 2, 2019
8. 
   Empact commented at 8:17 am on February 3, 2019: member

   utACK https://github.com/bitcoin/bitcoin/commit/fae169c95e09ddf068dcaebc8170c4f41b02cf66
9. 
   practicalswift commented at 9:19 am on February 3, 2019: contributor

   utACK fae169c95e09ddf068dcaebc8170c4f41b02cf66
10. 
    laanwj commented at 11:26 am on February 4, 2019: member

    utACK fae169c95e09ddf068dcaebc8170c4f41b02cf66
11. laanwj merged this on Feb 4, 2019
12. laanwj closed this on Feb 4, 2019

    ---

13. laanwj referenced this in commit 424327e1a8 on Feb 4, 2019
14. 
    practicalswift commented at 12:20 pm on February 4, 2019: contributor

    Thanks for merging.

    Reviewers of this PR might be interested in reviewing #15327 which makes the test updatecoins_simulation_test deterministic.

15. MarcoFalke deleted the branch on Feb 4, 2019
16. MarcoFalke referenced this in commit 9e7f8f6c82 on Feb 5, 2019
17. codablock referenced this in commit a284ce788d on Apr 12, 2020
18. codablock referenced this in commit a06be67a97 on Apr 12, 2020
19. codablock referenced this in commit 4487091d5a on Apr 12, 2020
20. codablock referenced this in commit 60d2b66a07 on Apr 14, 2020
21. codablock referenced this in commit d4065e79ac on Apr 14, 2020
22. ckti referenced this in commit 21c842ba47 on Mar 28, 2021
23. random-zebra referenced this in commit 93f43f0f81 on Apr 14, 2021
24. PastaPastaPasta referenced this in commit 7fe7b445f2 on Jun 27, 2021
25. PastaPastaPasta referenced this in commit 3b989cd794 on Jun 28, 2021
26. PastaPastaPasta referenced this in commit 28b30d5464 on Jun 28, 2021
27. PastaPastaPasta referenced this in commit 4eafb4dea6 on Jun 29, 2021
28. MarcoFalke locked this on Dec 16, 2021

Contributors
MarcoFalke Empact practicalswift laanwj

Labels
Tests