Suggested wallet code cleanups from #14711 #15342

1. 
   ryanofsky commented at 4:46 pm on February 4, 2019: member

   This implements suggested changes from #14711 review comments that didn’t make make it in before merging.

   There are no changes in behavior in this PR, just documentation updates, simplifications, and variable renames.

2. Rename ScanResult stop_block field

   Avoid confusion with stop_block argument as suggested
   https://github.com/bitcoin/bitcoin/pull/14711#discussion_r252038449

   95a812b599
3. Update ScanForWalletTransactions result comment

   Suggested https://github.com/bitcoin/bitcoin/pull/14711#discussion_r252038666

   a8d645c934
4. Add suggested rescanblockchain comments

   From https://github.com/bitcoin/bitcoin/pull/14711#discussion_r252043990

   db2d093233
5. Document rescanblockchain returned stop_height being null

   Suggested https://github.com/bitcoin/bitcoin/pull/14711#discussion_r252031485

   2efa66b464
6. Fix ScanForWalletTransactions start_block comment

   Suggested https://github.com/bitcoin/bitcoin/pull/14711#discussion_r252036436

   84adb206fc
7. Drop redundant get_value_or

   Suggested https://github.com/bitcoin/bitcoin/pull/14711#discussion_r252041954

   2c1fbaa771
8. Rename Chain getLocator -> getTipLocator

   Suggested https://github.com/bitcoin/bitcoin/pull/14711#discussion_r252044389

   aebafd0edf
9. 
   DrahtBot commented at 5:14 pm on February 4, 2019: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #14942 (wallet: Make scan / abort status private to CWallet by Empact)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

10. 
    MarcoFalke commented at 6:14 pm on February 4, 2019: member

    ACK aebafd0edf81b546d4b7db9e7f53e9eef2c0073e. Thanks for the responses to my questions in the other pull!
11. MarcoFalke added this to the milestone 0.18.0 on Feb 4, 2019
12. MarcoFalke added the label Refactoring on Feb 4, 2019
13. 
    promag commented at 7:01 pm on February 4, 2019: member

    ACK aebafd0, agreed on renames and updated comments.
14. 
    fanquake commented at 3:14 pm on February 5, 2019: member

    utACK aebafd0
15. MarcoFalke merged this on Feb 5, 2019
16. MarcoFalke closed this on Feb 5, 2019

    ---

17. MarcoFalke referenced this in commit bbdcc0b0ff on Feb 5, 2019
18. 
    jnewbery commented at 4:00 pm on February 5, 2019: member

    utACK aebafd0edf81b546d4b7db9e7f53e9eef2c0073e. Hooray for quick merges :tada:
19. deadalnix referenced this in commit 7bd5ac0f8c on May 4, 2020
20. PastaPastaPasta referenced this in commit d5723b805a on Oct 23, 2021
21. PastaPastaPasta referenced this in commit 0ad7780ae1 on Oct 24, 2021
22. PastaPastaPasta referenced this in commit b4a0369af8 on Oct 25, 2021
23. PastaPastaPasta referenced this in commit 75eea2cdb0 on Oct 25, 2021
24. PastaPastaPasta referenced this in commit a941bfc417 on Nov 1, 2021
25. PastaPastaPasta referenced this in commit c77a227ab9 on Nov 1, 2021
26. PastaPastaPasta referenced this in commit dfa040e9b9 on Nov 3, 2021
27. pravblockc referenced this in commit 30cf1bbae2 on Nov 18, 2021
28. MarcoFalke locked this on Dec 16, 2021

Contributors
ryanofsky DrahtBot MarcoFalke promag fanquake jnewbery

Labels
Refactoring

Milestone
0.18.0