Interrupting CWallet::AddToWallet requires rescan #1535

If I interrupt CWallet::AddToWallet at the start, while it is adding a new coinbase transaction (or probably any first-seen-in-block) - for example with "quit" in GDB or SIGKILL - after restarting, Bitcoin-Qt (and bitcoind?) will not pick up on this transaction even after completely catching up. -rescan is then needed to see it.

Based on the reports on IRC we clearly have some cases where txn are get missed but I've not seen any easy way to pin them down. Assuming the issues are shutdown related. It might be useful to always rescan the last couple block before the wallets claimed height.

I was hoping the details in this report would make finding and fixing the real cause easier :)

This may be because SetBestChain is called when the block state is flushed, irregardless of whether the wallet is currently doing ScanForWalletTransactions. eg if a user starts Bitcoin Core, it is running wallet scan, they try to stop the node, and it takes too long so they kill it (because wallet rescan is uninterruptible, I believe), the wallet best tip pointer may be set based on blocks which were flushed to disk (eg via FlushStateToDisk() in Shutdown()).

Bump. What could be done here?

I'd bet this is no longer a bug, and given it was never reported to be reproduceible, I'd suggest close.