build: Bump minimum Qt version to 5.5.1 #15393

pull Sjors wants to merge 1 commits into bitcoin:master from Sjors:2019/02/qt-5_5 changing 6 files +8 −32
  1. Sjors commented at 7:30 pm on February 12, 2019: member

    Fixes #13478

    Compiled and lightly tested on 10.14.3 against QT 5.12.0.

  2. MarcoFalke renamed this:
    Bump minimum Qt version to 5.5.1
    build: Bump minimum Qt version to 5.5.1
    on Feb 12, 2019
  3. MarcoFalke added the label Build system on Feb 12, 2019
  4. MarcoFalke added this to the milestone 0.18.0 on Feb 12, 2019
  5. luke-jr commented at 8:53 pm on February 12, 2019: member

    Is there an actual benefit to this?

    Has anyone done a check for what versions come with current stable distros?

  6. MarcoFalke commented at 9:10 pm on February 12, 2019: member

    Examples:

    Also,

    • 5.5.1 is long EOL anyway and it’d be better if the user built qt from our depends
    • Bitcoin Core wouldn’t compile with qt5.2 anyway
  7. fanquake commented at 1:25 am on February 13, 2019: member
    Concept ACK
  8. in build-aux/m4/bitcoin_qt.m4:119 in 45855af9e6 outdated 
    132-      [bitcoin_cv_need_acc_widget=no])
133-    ])
134-    if test "x$bitcoin_cv_need_acc_widget" = xyes; then
135-      _BITCOIN_QT_CHECK_STATIC_PLUGINS([Q_IMPORT_PLUGIN(AccessibleFactory)], [-lqtaccessiblewidgets])
136-    fi
137+    _BITCOIN_QT_CHECK_STATIC_PLUGINS([Q_IMPORT_PLUGIN(AccessibleFactory)], [-lqtaccessiblewidgets])
    fanquake commented at 1:26 am on February 13, 2019:
    Pretty sure you need to drop this line as well (it’s causing the macOS and windows Travis builds to fail: https://travis-ci.org/bitcoin/bitcoin/jobs/492335743#L1641).
    Sjors commented at 8:17 am on February 13, 2019:
    Indeed, bitcoin_cv_need_acc_widget would have been xno before.
  9. in doc/dependencies.md:26 in 45855af9e6 outdated 
    22@@ -23,7 +23,7 @@ These are the dependencies currently used by Bitcoin Core. You can find instruct
23 | protobuf | [2.6.1](https://github.com/google/protobuf/releases) |  | No |  |  |
24 | Python (tests) |  | [3.4](https://www.python.org/downloads) |  |  |  |
25 | qrencode | [3.4.4](https://fukuchi.org/works/qrencode) |  | No |  |  |
26-| Qt | [5.9.7](https://download.qt.io/official_releases/qt/) | [5.2](https://github.com/bitcoin/bitcoin/pull/14725) | No |  |  |
27+| Qt | [5.9.7](https://download.qt.io/official_releases/qt/) | 5.5.1 | No |  |  |
    fanquake commented at 1:27 am on February 13, 2019:
    Could you (assuming it is merged) link to this PR as a reference? It’s useful when referring to the docs to be able to jump straight to the PR/discussion that bumped a dependency.
  10. jonasschnelli commented at 6:26 am on February 13, 2019: contributor
    Concept ACK
  11. Sjors force-pushed on Feb 13, 2019
  12. Sjors commented at 8:18 am on February 13, 2019: member

    @luke-jr wrote:

    Is there an actual benefit to this?

    See discussion in #13478

    I added a link to that discussion in doc/dependencies.md and dropped the Q_IMPORT_PLUGIN(AccessibleFactory) line.

  13. in src/qt/test/apptests.cpp:30 in a4d80ff95a outdated 
    26@@ -27,9 +27,7 @@
27 #include <QTest>
28 #include <QTextEdit>
29 #include <QtGlobal>
30-#if QT_VERSION >= 0x050000
31 #include <QtTest/QtTestWidgets>
    practicalswift commented at 10:58 am on February 13, 2019:
    Could sort includes :-)
  14. in build-aux/m4/bitcoin_qt.m4:261 in a4d80ff95a outdated 
    257@@ -276,7 +258,7 @@ AC_DEFUN([_BITCOIN_QT_CHECK_QT5],[
258       #endif
259     ]],
260     [[
261-      #if QT_VERSION < 0x050200 || QT_VERSION_MAJOR < 5
262+      #if QT_VERSION < 0x050501 || QT_VERSION_MAJOR < 5
    flack commented at 12:14 pm on February 13, 2019:
    is the QT_VERSION_MAJOR clause still needed? At first glance, it looks like a leftover from when Qt 4 was still supported
    Sjors commented at 2:53 pm on February 13, 2019:
    I was assuming this is a generic check to see if QT >=5.5.1 is present at all, but haven’t tried what happens with older QT versions.
    flack commented at 3:39 pm on February 13, 2019:
    according to https://doc.qt.io/qt-5/qtglobal.html#QT_VERSION if QT_MAJOR_VERSION is 4, then QT_VERSION should be something like 0x040102, so it would already fail the first clause. IOW, I don’t think there is any constellation where the first clause is false and the second one is true
    MarcoFalke commented at 3:43 pm on February 13, 2019:
    Could ask @TheCharlatan if there was a reason to do this in 28482efefb15dc2c273a52b96d1aceb995db4968
    Sjors commented at 4:11 pm on February 13, 2019:
    @flack I thought you were referring to the entire line. Yes, I agree the || QT_VERSION_MAJOR < 5 bit seems redundant. That maybe have been in order to support both 4.x and 5.x from certain minor versions onward.
    TheCharlatan commented at 9:33 am on February 14, 2019:
    I was confused about what the actual supported minor version was at the time. Either way, it is definitely redundant with this pr.
  15. MarcoFalke added the label Needs gitian build on Feb 13, 2019
  16. fanquake commented at 1:22 am on February 14, 2019: member
    @Sjors Could you add release notes to this PR as well?
  17. fanquake added the label Needs release note on Feb 14, 2019
  18. DrahtBot commented at 8:11 am on February 14, 2019: member

    Gitian builds for commit 0d1160e42185983b398cbc2e2be379002f4a62e9 (master):

    Gitian builds for commit 1dae32ea42ef252b3b4be62858b73afb81adff81 (master and this pull):

  19. DrahtBot removed the label Needs gitian build on Feb 14, 2019
  20. Sjors force-pushed on Feb 14, 2019
  21. Sjors commented at 9:13 am on February 14, 2019: member
    Added release note. The gitian binaries should still be valid.
  22. Bump minimum Qt version to 5.5.1 fd46c4c001
  23. Sjors force-pushed on Feb 14, 2019
  24. Sjors commented at 10:12 am on February 14, 2019: member
    I removed the redundant || QT_VERSION_MAJOR < 5.
  25. MarcoFalke commented at 7:33 pm on February 14, 2019: member

    There was a discussion on IRC that debian 8 comes with 5.3 (https://packages.debian.org/jessie/qt5-default)

    The conclusion was that anyone on debian 8 should use our ./depends qt package: http://www.erisian.com.au/bitcoin-core-dev/log-2019-02-14.html#l-405

  26. hebasto commented at 8:13 pm on February 14, 2019: member
    utACK fd46c4c0018c41d36cd892ccb47485b572d65837
  27. MarcoFalke commented at 8:15 pm on February 14, 2019: member
    utACK fd46c4c0018c41d36cd892ccb47485b572d65837
  28. jonasschnelli merged this on Feb 14, 2019
  29. jonasschnelli closed this on Feb 14, 2019
  30. jonasschnelli referenced this in commit 3b33cbc2b6 on Feb 14, 2019
  31. Sjors deleted the branch on Feb 14, 2019
  32. fanquake removed the label Needs release note on Mar 20, 2019
  33. lucayepa commented at 5:22 am on March 27, 2019: contributor

    Ok, I’m late to the party, but we are going to have a release that will not build both on Debian Jessie (QT 5.3.2) and Ubuntu Trusty (QT 5.2.1).

    I agree with @jonasschnelli :

    “but we need to expect users run it close to the LTS end”.

    The LTS end date of Ubuntu Trusty is April 2019. The LTS end date of Debian Jessie is June 30, 2020.

    IMO we should have a policy not to break compatibility with LTS distributions, unless this is really something we need (i.e. bugs or big issues).

  34. Sjors commented at 8:45 am on March 27, 2019: member
    @lucayepa it’s better to bring this up in #13478.
  35. MarcoFalke commented at 12:37 pm on March 27, 2019: member

    @lucayepa It hasn’t been building on those distros before this pull request because no one cared (found it worthwhile) to fix the code

    Trusty will be EOL before the final release and if you are on oldstable debian, you can build from depends or use the deterministic binaries.

  36. laanwj referenced this in commit aca76b9ee8 on Aug 29, 2019
  37. jonasschnelli referenced this in commit bcf7004a89 on Aug 29, 2019
  38. sidhujag referenced this in commit d286a2297a on Aug 29, 2019
  39. sidhujag referenced this in commit 718fc65a25 on Aug 29, 2019
  40. deadalnix referenced this in commit 8d97e27d54 on Feb 29, 2020
  41. deadalnix referenced this in commit 5bd3474905 on Feb 29, 2020
  42. ftrader referenced this in commit 45702480fa on Apr 16, 2020
  43. ftrader referenced this in commit 9149f81631 on Apr 16, 2020
  44. 10xcryptodev referenced this in commit c539cc6397 on May 14, 2020
  45. 10xcryptodev referenced this in commit 6ff92ca28f on May 15, 2020
  46. 10xcryptodev referenced this in commit 9c9367efb3 on May 17, 2020
  47. 10xcryptodev referenced this in commit 8ef5bc4ad4 on May 20, 2020
  48. 10xcryptodev referenced this in commit 76cfc7c912 on Jun 12, 2020
  49. monstrobishi referenced this in commit 290cc97dd5 on Jul 30, 2020
  50. monstrobishi referenced this in commit 601838d1ea on Jul 30, 2020
  51. fanquake referenced this in commit 38c13a4a60 on Aug 24, 2020
  52. sidhujag referenced this in commit dafb919f5c on Aug 24, 2020
  53. ShengguangXiao referenced this in commit fdfcde0804 on Aug 28, 2020
  54. ShengguangXiao referenced this in commit f038d96530 on Aug 28, 2020
  55. xdustinface referenced this in commit 3e8687603d on Feb 17, 2021
  56. gades referenced this in commit 0959261b18 on Jun 27, 2021
  57. gades referenced this in commit 0e12d032a0 on Jun 27, 2021
  58. PastaPastaPasta referenced this in commit dd7f6413f4 on Sep 11, 2021
  59. PastaPastaPasta referenced this in commit 194bb53c06 on Sep 11, 2021
  60. PastaPastaPasta referenced this in commit 9d1541ad2c on Sep 12, 2021
  61. PastaPastaPasta referenced this in commit 9bb9390ad1 on Sep 12, 2021
  62. PastaPastaPasta referenced this in commit 54bfed144f on Sep 14, 2021
  63. DrahtBot locked this on Dec 16, 2021


Sjors luke-jr MarcoFalke fanquake jonasschnelli practicalswift flack TheCharlatan DrahtBot hebasto lucayepa

Labels
Build system

Milestone
0.18.0

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-05 01:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me