docs: make it clearer that posix mode must be used in WSL #15396

pull yunchiri wants to merge 1 commits into bitcoin:master from yunchiri:patch-1 changing 1 files +3 −2

yunchiri commented at 7:38 AM on February 13, 2019: none

clearly tell to person what select mode
Update build-windows.md
clearly tell to person what select mode
0811e14cab
fanquake added the label Docs on Feb 13, 2019

in doc/build-windows.md:80 in 0811e14cab

  76 | @@ -77,9 +77,10 @@ The first step is to install the mingw-w64 cross-compilation tool chain:
  77 |  
  78 |      sudo apt install g++-mingw-w64-x86-64
  79 |  
  80 | -Ubuntu Bionic 18.04 <sup>[1](#footnote1)</sup>:
  81 | +Ubuntu Bionic 18.04 <sup>[1](#footnote1)</sup> (select posix mode):

practicalswift commented at 10:13 AM on February 14, 2019:

Trailing whitespace :-)

in doc/build-windows.md:83 in 0811e14cab

  76 | @@ -77,9 +77,10 @@ The first step is to install the mingw-w64 cross-compilation tool chain:
  77 |  
  78 |      sudo apt install g++-mingw-w64-x86-64
  79 |  
  80 | -Ubuntu Bionic 18.04 <sup>[1](#footnote1)</sup>:
  81 | +Ubuntu Bionic 18.04 <sup>[1](#footnote1)</sup> (select posix mode): 
  82 |  
  83 | -    sudo update-alternatives --config x86_64-w64-mingw32-g++ # Set the default mingw32 g++ compiler option to posix.
  84 | +    sudo update-alternatives --config x86_64-w64-mingw32-g++ # Set the default mingw32 g++ compiler option to posix
  85 | +

practicalswift commented at 10:13 AM on February 14, 2019:

Nit: Multiple consecutive blank lines.

fanquake commented at 2:22 AM on February 15, 2019: member

Are the comments behind each update-alternatives instruction, plus the footnote not enough?

If you are going to make these changes, you should do it for the 32 bit instructions as well. Also needs a proper commit message (squash any fix-ups into a single commit).
fanquake renamed this:
~~Update build-windows.md~~
docs: make it clearer that posix mode must be used in WSL
on Feb 15, 2019
yunchiri commented at 3:10 AM on February 15, 2019: none

@fanquake as newbie, footnote is not enough get information before click I think tell what select mode in construction step clearly! Thanks feedback
yunchiri closed this on Feb 15, 2019
fanquake commented at 3:13 AM on February 15, 2019: member

@yunchiri If you are going to make the updates, you can reopen and push changes to this Pull Request, you don't have to open a new one.
MarcoFalke locked this on Dec 16, 2021

Contributors

Labels