[depends] update to Boost 1.70 #15461

pull Sjors wants to merge 1 commits into bitcoin:master from Sjors:2019/02/depends_boost changing 4 files +138 −129
  1. Sjors commented at 10:12 am on February 22, 2019: member

    Version 1.70 is most recent.

    Versions needed for:

  2. Sjors commented at 10:14 am on February 22, 2019: member
    Other than iOs support, are there are any other reasons for updating the Boost version? Otherwise this can wait until #12557 is closer to merge readiness. @fanquake [suggested]( #12557 (review)) bumping straight to 1.69
  3. fanquake added the label Build system on Feb 22, 2019
  4. Sjors force-pushed on Feb 22, 2019
  5. MarcoFalke added this to the milestone 0.19.0 on Feb 22, 2019
  6. MarcoFalke added the label Needs gitian build on Feb 22, 2019
  7. MarcoFalke commented at 1:31 pm on February 22, 2019: member
    This is sporadically updated to the latest version, so might as well do 1.69
  8. Sjors commented at 1:47 pm on February 22, 2019: member

    Mmm, Travis build for 32-bit ARM is unhappy:

    0undefined reference to `boost::system::system_category()

    I’ll try if 1.69 magically makes that problem go away.

  9. Sjors renamed this:
    [depends] update to Boost 1.66
    [depends] update to Boost 1.69
    on Feb 22, 2019
  10. Sjors force-pushed on Feb 22, 2019
  11. MarcoFalke removed the label Needs gitian build on Feb 22, 2019
  12. fanquake commented at 5:52 am on February 23, 2019: member
    Concept ACK. Will review release notes and test depends builds etc.
  13. MarcoFalke added the label Needs gitian build on Feb 23, 2019
  14. DrahtBot removed the label Needs gitian build on Feb 24, 2019
  15. fanquake commented at 6:42 am on March 15, 2019: member

    Relevant release notes from Boost 1.65.0 -> 1.69.0:

    1.69.0

    Filesystem

    • Fixed crashes in boost::filesystem::copy due to undefined behavior in the implementation.
    • Fixed undefined behavior in boost::filesystem::directory_iterator implementation.
    • Fixed MSVC warnings about narrowing conversions.

    System

    • Boost.System is now header-only. A stub library is still built for compatibility, but linking to it is no longer necessary.
    • The destructor of error_category is now protected and no longer virtual. This is a potentially breaking change, but its impact is expected to be limited.

    1.68.0

    Boost.WinAPI has been updated to target Windows 7 by default, where possible. In previous releases Windows Vista was the default.

    Test

    • Breaking change: The master_test_suite_t object is no more copyable

    1.67.0

    Filesystem

    • Fix static initialization issue that caused a crash if path operations were used before main()

    Test

    • Breaking change: Adding test cases with the same name to the same test suite is now reported as an error. See the changes log for more details.

    1.66.0

    Thread

    • Many Windows related fixes.

    1.65.0

    Test

    • C++17 compatibility (tested on VS2017)

    Breaking Changes

    • Some API changes for the loggers
    • Deprecating BOOST_GLOBAL_FIXTURE in favor of BOOST_TEST_GLOBAL_FIXTURE and BOOST_TEST_GLOBAL_CONFIGURATION.
  16. promag commented at 9:25 pm on April 29, 2019: member

    Concept ACK.

    Then this could be updated:https://github.com/bitcoin/bitcoin/blob/ce6762030f814bc737bb0a097c17201e0b2edbc5/src/wallet/walletutil.cpp#L70-L72

    Edit: this too https://github.com/bitcoin/bitcoin/blob/master/doc/dependencies.md#L9

  17. MarcoFalke deleted a comment on Apr 30, 2019
  18. hebasto commented at 8:50 am on May 2, 2019: member
    Concept ACK. Agree with @promag’s comments.
  19. Sjors force-pushed on May 2, 2019
  20. Sjors commented at 10:12 am on May 2, 2019: member
    Rebased and adjusted the version in dependencies.md. We can’t change walletutil.cpp because the minimum Boost version (1.47.0) doesn’t change with this PR. Changing the minimum version can be done in a followup, but there’s no urgent need afaik.
  21. MarcoFalke added the label Needs gitian build on May 2, 2019
  22. [depends] boost: update to 1.70 2620e24b83
  23. Sjors force-pushed on May 3, 2019
  24. Sjors commented at 1:17 pm on May 3, 2019: member
    I switched from Boost 1.69 to 1.70
  25. Sjors renamed this:
    [depends] update to Boost 1.69
    [depends] update to Boost 1.70
    on May 3, 2019
  26. practicalswift commented at 1:23 pm on May 3, 2019: contributor
    Concept ACK
  27. DrahtBot commented at 3:22 pm on May 3, 2019: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #10102 ([experimental] Multiprocess bitcoin by ryanofsky)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  28. DrahtBot commented at 3:28 am on May 5, 2019: member

    Gitian builds for commit 24dfcf3a56f90b101bc208f48ccdb7813fa08b83 (master):

    Gitian builds for commit c0d07f6dc9f7a39a4331d5a2af5a168c4ef57cd2 (master and this pull):

  29. DrahtBot removed the label Needs gitian build on May 5, 2019
  30. Sjors commented at 10:52 am on May 6, 2019: member
    Very lightly tested the macOS Gitian QT build.
  31. laanwj commented at 11:43 am on June 6, 2019: member
    ACK 2620e24b83d16bf0f2bfe360dee1e98b4be59ca5, let’s do this early in the 0.19 cycle
  32. laanwj merged this on Jun 6, 2019
  33. laanwj closed this on Jun 6, 2019
  34. laanwj referenced this in commit 36fb968825 on Jun 6, 2019
  35. in build-aux/m4/ax_boost_system.m4:111 in 2620e24b83 
    107@@ -109,7 +108,7 @@ AC_DEFUN([AX_BOOST_SYSTEM],
108 
109             fi
110             if test "x$ax_lib" = "x"; then
111-                AC_MSG_ERROR(Could not find a version of the boost_system library!)
112+                AC_MSG_ERROR(Could not find a version of the library!)
    laanwj commented at 11:53 am on June 6, 2019:
    This reverts (part of) 25333a26197b55c23debb38740ed875999aa795a but I don’t know if we care.
    Sjors commented at 12:18 pm on June 7, 2019:
    I didn’t realize we were using a patch on top of https://www.gnu.org/software/autoconf-archive/ax_boost_base.html
    Sjors commented at 12:24 pm on October 1, 2019:
    Oops: #17010
  36. MarcoFalke commented at 1:24 pm on June 6, 2019: member
    It seems that not even debian experimental is at 1.70. I guess that means we are the beta testers? Let’s hope debian ships it within the next couple of months.
  37. kristapsk commented at 2:34 pm on June 6, 2019: contributor
    On Gentoo it exists but is masked (not stable).
  38. sidhujag referenced this in commit f4f8f11df3 on Jun 6, 2019
  39. Sjors deleted the branch on Jun 7, 2019
  40. eugene-sy referenced this in commit 8b8eb89b8a on Jun 11, 2019
  42. deadalnix referenced this in commit 53a3ec1060 on Apr 1, 2020
  43. ftrader referenced this in commit def73e3596 on Aug 17, 2020
  44. xdustinface referenced this in commit d390a1412e on Feb 17, 2021
  45. DrahtBot locked this on Dec 16, 2021


Sjors MarcoFalke fanquake promag hebasto practicalswift DrahtBot laanwj kristapsk

Labels
Build system

Milestone
0.19.0

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-07-05 19:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me