fuzz: Link BasicTestingSetup (shared with unit tests) #15504

1. 
   MarcoFalke commented at 7:55 pm on February 28, 2019: member

   Link against BasicTestingSetup in the fuzz tests, so we can fuzz against validation.

   Also include a commit to remove test_bitcoin_main.cpp. That file may or may not overwrite globals in the link stage depending on the link order. This is confusing and useless anyway: The unit tests should never std::exit in the middle of the run (especially with success as exit code), since it will skip all test modules afterward.

   Also include a commit to remove some unused forward declarations and move the main_tests to validation_tests, since main was long ago split into net_processing and validation.

2. 
   practicalswift commented at 7:58 pm on February 28, 2019: contributor

   Concept ACK

   Nice cleanup: -242 lines of code

3. test: Add missing LIBBITCOIN_ZMQ to test_test_bitcoin_LDADD fab2daa026
4. test: Remove useless test_bitcoin_main.cpp fa02b22245
5. test: Move main_tests to validation_tests fa85468cd2
6. fuzz: Link BasicTestingSetup (shared with unit tests) faa9b88199
7. MarcoFalke force-pushed on Feb 28, 2019
8. 
   DrahtBot commented at 9:32 pm on February 28, 2019: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #15382 ([util] add runCommandParseJSON by Sjors)
   • #14464 (refactor: make checkqueue manage the threads by itself (also removed some boost dependencies) by ken2812221)
   • #10102 ([experimental] Multiprocess bitcoin by ryanofsky)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

9. fanquake added the label Tests on Feb 28, 2019
10. MarcoFalke renamed this:
    test: Remove useless test_bitcoin_main.cpp
    fuzz: Link BasicTestingSetup (shared with unit tests)
    on Mar 6, 2019
11. ryanofsky approved
12. 
    ryanofsky commented at 7:43 pm on March 6, 2019: member

    utACK faa9b88199c382c04e3aaa2b63479f9066ce8f9c. Looks good, bunch of nice simple make & test cleanups.
13. MarcoFalke referenced this in commit df36ddf9ce on Mar 6, 2019
14. MarcoFalke merged this on Mar 6, 2019
15. MarcoFalke closed this on Mar 6, 2019

    ---

16. MarcoFalke deleted the branch on Mar 6, 2019
17. MarcoFalke referenced this in commit 78295e97b8 on Apr 15, 2019
18. deadalnix referenced this in commit eeb9bdcc26 on Mar 16, 2020
19. deadalnix referenced this in commit 937ea822e7 on Mar 19, 2020
20. ftrader referenced this in commit 93570b9a24 on May 19, 2020
21. kittywhiskers referenced this in commit 08a256eb55 on Aug 2, 2021
22. kittywhiskers referenced this in commit c012570198 on Aug 5, 2021
23. kittywhiskers referenced this in commit ca13e682bf on Aug 5, 2021
24. kittywhiskers referenced this in commit 489451fffa on Aug 5, 2021
25. PastaPastaPasta referenced this in commit 6915642554 on Aug 6, 2021
26. kittywhiskers referenced this in commit 77a3e1e888 on Aug 8, 2021
27. kittywhiskers referenced this in commit f202a902bf on Aug 11, 2021
28. PastaPastaPasta referenced this in commit 90e7119a8b on Aug 11, 2021
29. 5tefan referenced this in commit c51f268b26 on Aug 12, 2021
30. Munkybooty referenced this in commit 77ed0cb41e on Oct 7, 2021
31. Munkybooty referenced this in commit 230fe8793d on Oct 7, 2021
32. Munkybooty referenced this in commit 45fbb95f04 on Oct 12, 2021
33. DrahtBot locked this on Dec 16, 2021

Contributors
MarcoFalke practicalswift DrahtBot ryanofsky

Labels
Tests