test: .style.yapf: Set column_limit=160 #15533

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:1903-testNoPep8Collim changing 1 files +1 −1
  1. MarcoFalke commented at 11:33 PM on March 4, 2019: member

    The current style is pep8, as suggested in https://github.com/bitcoin/bitcoin/blob/master/test/functional/README.md#style-guidelines.

    generated with

    $ yapf --version 
    yapf 0.24.0
    $ yapf --style-help --style=pep8 > .style.yapf
    

    However, we don't use the column_limit of 79 right now. Practically it is somewhere between 120-240.

    Some stats:

    column_limit=120: 115 files changed, 2423 insertions(+), 1408 deletions(-)
    column_limit=160: 108 files changed, 1563 insertions(+), 1247 deletions(-)
    column_limit=200: 104 files changed, 1255 insertions(+), 1178 deletions(-)
    
  2. test: .style.yapf: Set column_limit=160 1111f0718a
  3. fanquake added the label Tests on Mar 4, 2019
  4. MarcoFalke commented at 11:35 PM on March 4, 2019: member

    Please bikeshed, as I don't care what the limit is, as long as it is >=120.

    It is unlimited for our cpp: https://github.com/bitcoin/bitcoin/blob/14023c966c51a0a14a2e4477fbe3e5d810f91076/src/.clang-format#L21

  5. ryanofsky approved
  6. ryanofsky commented at 4:44 PM on March 20, 2019: member

    utACK 1111f0718acea42954600a4dbd553ac40aae797f

    Please bikeshed, as I don't care what the limit is, as long as it is >=120.

    I actually like 79 columns best like pep8 recommends (https://www.python.org/dev/peps/pep-0008/#maximum-line-length), but that's about as much as I want to bikeshed. This change looks good to me.

  7. practicalswift commented at 4:47 PM on March 20, 2019: contributor

    utACK 1111f0718acea42954600a4dbd553ac40aae797f agree with @ryanofsky

  8. MarcoFalke merged this on Mar 29, 2019
  9. MarcoFalke closed this on Mar 29, 2019

  10. MarcoFalke referenced this in commit 00ca24b68f on Mar 29, 2019
  11. MarcoFalke deleted the branch on Mar 29, 2019
  12. PastaPastaPasta referenced this in commit dd537bae97 on Jun 27, 2021
  13. PastaPastaPasta referenced this in commit b4347e66b9 on Jun 28, 2021
  14. PastaPastaPasta referenced this in commit 9c1c8c8c00 on Jun 29, 2021
  15. PastaPastaPasta referenced this in commit f4544c822d on Jul 1, 2021
  16. PastaPastaPasta referenced this in commit e4c728660d on Jul 1, 2021
  17. PastaPastaPasta referenced this in commit 1d7a04e3f6 on Jul 8, 2021
  18. PastaPastaPasta referenced this in commit dc25ff6294 on Jul 10, 2021
  19. MarcoFalke locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 06:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me