cli: replace testnet with chain and return network name as per BIP70. #15566

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:cli-testnet-to-network changing 3 files +5 −2
  1. fanquake commented at 8:39 AM on March 9, 2019: member

    Related IRC discussion here (line 151).

  2. cli: replace testnet with chain and return network name as per BIP70. 890396cbd5
  3. fanquake added the label Utils/log/libs on Mar 9, 2019
  4. luke-jr commented at 8:58 AM on March 9, 2019: member

    Shouldn't we retain "testnet" for compatibility, for now?

  5. laanwj commented at 9:09 AM on March 9, 2019: member

    Shouldn't we retain "testnet" for compatibility, for now?

    Now that it's client-side, IMO there's no strict need for keeping compatibility at all (you could always use a different bitcoin-cli executable). We've already let this linger for way too long.

  6. laanwj commented at 9:09 AM on March 9, 2019: member

    ACK 890396cbd504b4670597d39ecb037e69ffb8bd3e

  7. MarcoFalke commented at 3:05 PM on March 9, 2019: member

    ACK 890396c

  8. Empact commented at 3:48 PM on March 9, 2019: member

    utACK https://github.com/bitcoin/bitcoin/pull/15566/commits/890396cbd504b4670597d39ecb037e69ffb8bd3e

    nit: I also like the idea of explicit deprecation

  9. IlyasRidhuan commented at 8:18 AM on March 10, 2019: none

    ACK 890396c

  10. MarcoFalke merged this on Mar 11, 2019
  11. MarcoFalke closed this on Mar 11, 2019
  12. MarcoFalke referenced this in commit 887f57eb72 on Mar 11, 2019
  13. fanquake deleted the branch on Mar 11, 2019
  14. jasonbcox referenced this in commit 406bb3cac2 on Oct 2, 2020
  15. Munkybooty referenced this in commit ca73e0447c on Sep 21, 2021
  16. Munkybooty referenced this in commit b8d214ab1f on Sep 21, 2021
  17. Munkybooty referenced this in commit 52bbfc05ec on Sep 27, 2021
  18. Munkybooty referenced this in commit 046bae2d4d on Sep 27, 2021
  19. Munkybooty referenced this in commit 6011ac41e6 on Sep 30, 2021
  20. Munkybooty referenced this in commit 1e0aa634b2 on Oct 1, 2021
  21. kittywhiskers referenced this in commit 27d3173bda on Oct 12, 2021
  22. pravblockc referenced this in commit 5d0ae4904f on Nov 18, 2021
  23. DrahtBot locked this on Dec 16, 2021
Contributors
fanquakeluke-jrlaanwjMarcoFalkeEmpactIlyasRidhuan
Labels
Utils/log/libs
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me