depends: native_protobuf: avoid system zlib #15580

pull dongcarl wants to merge 1 commits into bitcoin:master from dongcarl:2019-03-depends-native_protobuf-no-zlib changing 1 files +1 −1
  1. dongcarl commented at 5:07 PM on March 11, 2019: member

    I don't believe we use any zlib features in protobufs

  2. depends: native_protobuf: avoid system zlib 19a0c4af0f
  3. dongcarl added the label Needs gitian build on Mar 11, 2019
  4. dongcarl added the label Build system on Mar 11, 2019
  5. gmaxwell commented at 9:23 PM on March 11, 2019: contributor

    Won't protobufs be out of the build entirely by 0.19?

  6. dongcarl commented at 1:37 AM on March 12, 2019: member

    Won't protobufs be out of the build entirely by 0.19?

    Ah! Is it no longer a dependency?

  7. gmaxwell commented at 3:04 AM on March 12, 2019: contributor

    Not yet, but AFAIK thats the plan.

  8. fanquake commented at 3:04 AM on March 12, 2019: member

    @dongcarl It's still required. 0.18.0 introduced a flag to allow disabling BIP70 support (still enabled by default). I've opened #15584 to make disabling BIP70 support the default for 0.19.0. I assume we'll be able to remove it entirely (and thus the protobuf dependency) in 0.20.0.

  9. dongcarl commented at 3:16 AM on March 12, 2019: member

    Ah okay. Well I guess this change will be relevant for a little bit at least :-)

  10. DrahtBot commented at 1:54 PM on March 12, 2019: member

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds for commit c94852e7912eb0881eb38af28cd2e3076e53e393 (master):

    Gitian builds for commit 128ccc923dfa27f880832a72fe72ea96e5ef43d3 (master and this pull):

  11. DrahtBot removed the label Needs gitian build on Mar 12, 2019
  12. MarcoFalke commented at 3:22 PM on March 12, 2019: member

    ACK

  13. fanquake commented at 6:06 AM on March 15, 2019: member

    utACK 19a0c4a

    Upstream protobuf configure --with-zlib:

    include classes for streaming compressed data in and out

  14. MarcoFalke merged this on Mar 15, 2019
  15. MarcoFalke closed this on Mar 15, 2019
  16. MarcoFalke referenced this in commit 118a5c8d94 on Mar 15, 2019
  17. deadalnix referenced this in commit 752632fd68 on Mar 31, 2020
  18. ftrader referenced this in commit 386860e1b7 on Aug 17, 2020
  19. PastaPastaPasta referenced this in commit 197747c69d on Jun 27, 2021
  20. PastaPastaPasta referenced this in commit da7662f3a7 on Jun 28, 2021
  21. PastaPastaPasta referenced this in commit e6bd7a926b on Jun 29, 2021
  22. PastaPastaPasta referenced this in commit 773290ab5a on Jul 1, 2021
  23. PastaPastaPasta referenced this in commit 0e2619f53e on Jul 1, 2021
  24. PastaPastaPasta referenced this in commit d40ec27e2c on Jul 8, 2021
  25. PastaPastaPasta referenced this in commit f334f63d3d on Jul 10, 2021
  26. MarcoFalke locked this on Dec 16, 2021
Contributors
dongcarlgmaxwellfanquakeDrahtBotMarcoFalke
Labels
Build system
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-01 03:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me