net: Generate log entry when blocks messages are received unexpectedly #15597

1. 
   pstratem commented at 1:02 AM on March 14, 2019: contributor

   Currently these are incorrectly logged as an unknown command.

2. Generate log entry when blocks messages are received unexpectedly. ef0019e054
3. pstratem force-pushed on Mar 14, 2019
4. 
   gmaxwell commented at 1:10 AM on March 14, 2019: contributor

   utACK

5. fanquake added the label P2P on Mar 14, 2019
6. fanquake added the label Utils/log/libs on Mar 14, 2019
7. 
   practicalswift commented at 10:09 AM on March 14, 2019: contributor

   Net effect of PR:

   Logged before:

   Unknown command "{cmpctblock,blocktxn,headers,block}" from peer=N

   Logged after:

   Unexpected {cmpctblock,blocktxn,headers,block} message received from peer N

   No change in behaviour AFAICT.

   utACK ef0019e054734a14214dfbce56611ce4db1688a5

8. 
   promag commented at 2:10 PM on March 14, 2019: member

   utACK ef0019e.

9. 
   MarcoFalke commented at 2:40 PM on March 14, 2019: member

   utACK ef0019e054734a14214dfbce56611ce4db1688a5

10. MarcoFalke renamed this:
    Generate log entry when blocks messages are received unexpectedly.
    net: Generate log entry when blocks messages are received unexpectedly
    on Mar 14, 2019
11. MarcoFalke added this to the milestone 0.19.0 on Mar 14, 2019
12. 
    naumenkogs commented at 4:18 PM on March 14, 2019: member

    utACK ef0019e

13. 
    laanwj commented at 7:36 PM on March 20, 2019: member

    Somehow we end up with code like this in the message handling every time. Let's try to pay attention to it in the future during reviews. utACK otherwise

14. laanwj merged this on Mar 20, 2019
15. laanwj closed this on Mar 20, 2019

    ---

16. laanwj referenced this in commit b3f82284ba on Mar 20, 2019
17. deadalnix referenced this in commit a242a8ddca on Jun 9, 2020
18. ftrader referenced this in commit cd1ea2923b on Aug 17, 2020
19. PastaPastaPasta referenced this in commit 6f25310c72 on Jun 25, 2021
20. PastaPastaPasta referenced this in commit 362f1ed526 on Jun 25, 2021
21. PastaPastaPasta referenced this in commit 2a425933d7 on Jun 26, 2021
22. PastaPastaPasta referenced this in commit ed3c25ee84 on Jun 27, 2021
23. PastaPastaPasta referenced this in commit 4089667b53 on Jun 28, 2021
24. PastaPastaPasta referenced this in commit 4ac20e4e68 on Jun 29, 2021
25. DrahtBot locked this on Dec 16, 2021

Contributors

pstratemgmaxwellpracticalswiftpromagMarcoFalkenaumenkogslaanwj

Milestone
0.19.0