refactor: Expose UndoReadFromDisk in header #15623

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:1903-UndoReadFromDiskHeader changing 2 files +7 −9

MarcoFalke commented at 4:56 PM on March 19, 2019: member
It is not possible to calculate the fee of a non-mempool transaction in RPCs unless txindex is active or the prevtxs are passed in through the RPC.

Fix that issue for confirmed txs by exposing UndoReadFromDisk in the header file.

This pull is a requirement for
- rpc: faster getblockstats using BlockUndo data #14802
- Index for BIP 157 block filters #14121
- my local patches
jamesob approved
jamesob commented at 4:58 PM on March 19, 2019: member

utACK https://github.com/bitcoin/bitcoin/pull/15623/commits/faad97747af51d731db5a49ff58214d2ce5da2c8
practicalswift commented at 5:01 PM on March 19, 2019: contributor

utACK faad97747af51d731db5a49ff58214d2ce5da2c8
DrahtBot added the label Refactoring on Mar 19, 2019
DrahtBot added the label Validation on Mar 19, 2019
DrahtBot commented at 5:35 PM on March 19, 2019: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #14121 (Index for BIP 157 block filters by jimpo)
- #14053 (Add address-based index (attempt 4?) by marcinja)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

in src/validation.cpp:1516 in faad97747a outdated

1512 | @@ -1515,6 +1513,8 @@ static bool UndoReadFromDisk(CBlockUndo& blockundo, const CBlockIndex *pindex)
1513 |      return true;
1514 |  }
1515 |  
1516 | +namespace {

jimpo commented at 6:15 PM on March 19, 2019:

Is this anonymous namespace still necessary? The two methods inside it are both static.

jimpo commented at 6:16 PM on March 19, 2019: contributor

Concept ACK
refactor: Expose UndoReadFromDisk in header fa11c036e9
MarcoFalke force-pushed on Mar 19, 2019
MarcoFalke commented at 6:46 PM on March 19, 2019: member

Removed namespace, as requested by @jimpo
jamesob commented at 6:59 PM on March 19, 2019: member

re-utACK https://github.com/bitcoin/bitcoin/pull/15623/commits/fa11c036e97f18d31cffaf7430fbe84fe44efbcc
jimpo commented at 7:03 PM on March 19, 2019: contributor

utACK fa11c03
FelixWeis commented at 7:04 PM on March 19, 2019: contributor

utACK fa11c03
practicalswift commented at 8:12 AM on March 20, 2019: contributor

utACK fa11c036e97f18d31cffaf7430fbe84fe44efbcc
ryanofsky approved
ryanofsky commented at 3:31 PM on March 20, 2019: member

utACK fa11c036e97f18d31cffaf7430fbe84fe44efbcc, makes sense
MarcoFalke merged this on Mar 20, 2019
MarcoFalke closed this on Mar 20, 2019
MarcoFalke referenced this in commit 93623eea71 on Mar 20, 2019
MarcoFalke deleted the branch on Jun 11, 2019
luke-jr referenced this in commit 09fd6af3c0 on Sep 3, 2019
deadalnix referenced this in commit 61d5f33296 on Jun 1, 2020
ftrader referenced this in commit 25bd4ebb15 on Aug 17, 2020
kittywhiskers referenced this in commit 8e057e676f on Aug 2, 2021
kittywhiskers referenced this in commit 91ff7f85aa on Aug 8, 2021
UdjinM6 referenced this in commit 6a44889dfc on Aug 11, 2021
kittywhiskers referenced this in commit 87a438e048 on Aug 12, 2021
UdjinM6 referenced this in commit 607bd4b6b5 on Aug 13, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Refactoring Validation

Linked (view graph)

#14121 Index for BIP 157 block filters #14802 rpc: faster getblockstats using BlockUndo data

refactor: Expose UndoReadFromDisk in header #15623

Conflicts